[GitHub] [incubator-doris] nimuyuhan commented on a change in pull request #6507: 【Bug】Some functions of doris push down mysql to run abnormally

[GitBox <gi...@apache.org>]

nimuyuhan commented on a change in pull request #6507:
URL: https://github.com/apache/incubator-doris/pull/6507#discussion_r698454186



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/OdbcScanNode.java
##########
@@ -169,7 +155,8 @@ private void createOdbcFilters(Analyzer analyzer) {
         }
         ArrayList<Expr> odbcConjuncts = Expr.cloneList(conjuncts, sMap);
         for (Expr p : odbcConjuncts) {
-            if (shouldPushDownConjunct(odbcType, p)) {
+            if (Config.enable_external_database_function_push_down) {

Review comment:
       I agree. The scenario I encountered was that the functions of different versions were different. For example, there was no json_extract in the version before mysql 5.7. From the user's point of view, individual functions should not cause the statement to be modified or the code cannot be executed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org