You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/29 12:58:58 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25399: Add missing option when pushing latest images to cache :(
potiuk opened a new pull request, #25399:
URL: https://github.com/apache/airflow/pull/25399
The #25380 re-introduced pushing image as latest on main success
and (as unfortunately happens) since this is only testable after
merge, a small bug crippled in making main build fail.
This flag should fix the problem.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25399: Add missing option when pushing latest images to cache :(
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25399:
URL: https://github.com/apache/airflow/pull/25399#issuecomment-1199256491
Yeah. Indeed ... As kinda expected in #25380 "testing after merge" revealed a bug :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25399: Add missing option when pushing latest images to cache :(
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25399:
URL: https://github.com/apache/airflow/pull/25399#issuecomment-1199257485
Resulted with https://github.com/apache/airflow/runs/7578816993?check_suite_focus=true#step:16:79 which clearly explains the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25399: Add missing option when pushing latest images to cache :(
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25399:
URL: https://github.com/apache/airflow/pull/25399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org