You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/05 10:39:33 UTC
[GitHub] [maven-surefire] pzygielo opened a new pull request #326: Fix message about forkCount parameter = 0
pzygielo opened a new pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536915372
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
@pzygielo
This is still only one file of change?
Pls squash your commits to one and rebase it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] MartinKanters commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536809495
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
Technically it is correct I think, but personally I would rewrite the middle sentence in the other way around. What do you think of: `Forking a JVM for tests improves test accuracy.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#issuecomment-739248381
May I ask for review, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] MartinKanters commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536890303
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
Sure thing, but I am just reviewing your PR, which you asked for. Thanks for fixing the grammar, it will definitely make it more clear. If you won't change it, I can do it tomorrow. I currently do not have the time for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo closed pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
pzygielo closed pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536894982
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
Thanks for checking - sure thing.
I was only bothered by the verb in first place. I have no opinion regarding middle sentence.
I just had to retrigger GHA twice (once for failing _GitHub CI for *Nix / build (macOS-latest)_, once for _GitHub CI for *Nix / build (ubuntu-latest)_) without changing my changes (one can check diffs for my forced pushes). Only then I marked this PR as ready for review and asked for one.
I have no intention to play with GHA again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536979022
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
Thanks for checking.
As there is no conflict - I'm not going to rebase.
As you by the rule do not create merge commits in this project - you can and do squash on merge - I'm not going to do it.
Instead I hope Martin's change will cover the case.
Have a nice day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536853375
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
Feel free to do so. As the maintainer - you can push to my branch. You can do separate PR if you prefer and close this one without merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] pzygielo commented on a change in pull request #326: Fix message about forkCount parameter = 0
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536894982
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );
Review comment:
Thanks for checking - sure thing.
I was only bothered by the verb in first place. I have no opinion regarding middle sentence.
I just had to retrigger Travis twice (once for failing _GitHub CI for *Nix / build (macOS-latest)_, once for _GitHub CI for *Nix / build (ubuntu-latest)_) without changing my changes (one can check diffs for my forced pushes). Only then I marked this PR as ready for review and asked for one.
I have no intention to play with Travis again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org