You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2013/10/07 19:25:11 UTC
Re: Review Request 14497: Incorporate comments from v1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14497/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 5:25 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Incorporate comments from v1
Bugs: KAFKA-1075
https://issues.apache.org/jira/browse/KAFKA-1075
Repository: kafka
Description (updated)
-------
KAFKA-1075.v2
KAFKA-1075.v1
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 08b4b7218f62f876eb95628bd6db78c0956c7f04
Diff: https://reviews.apache.org/r/14497/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 14497: Incorporate comments from v1
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14497/#review26740
-----------------------------------------------------------
config/tools-log4j.properties
<https://reviews.apache.org/r/14497/#comment52052>
Let's get rid of any change to this file
- Neha Narkhede
On Oct. 7, 2013, 5:25 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14497/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 5:25 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1075
> https://issues.apache.org/jira/browse/KAFKA-1075
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1075.v2
>
>
> KAFKA-1075.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 08b4b7218f62f876eb95628bd6db78c0956c7f04
>
> Diff: https://reviews.apache.org/r/14497/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14497: Rebase v2
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14497/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 5:58 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Rebase v2
Bugs: KAFKA-1075
https://issues.apache.org/jira/browse/KAFKA-1075
Repository: kafka
Description
-------
KAFKA-1075.v2
KAFKA-1075.v1
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 08b4b7218f62f876eb95628bd6db78c0956c7f04
Diff: https://reviews.apache.org/r/14497/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 14497: Incorporate comments from v1
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14497/#review26739
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Oct. 7, 2013, 5:25 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14497/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 5:25 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1075
> https://issues.apache.org/jira/browse/KAFKA-1075
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1075.v2
>
>
> KAFKA-1075.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 08b4b7218f62f876eb95628bd6db78c0956c7f04
>
> Diff: https://reviews.apache.org/r/14497/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>