You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Veena Basavaraj (JIRA)" <ji...@apache.org> on 2014/11/13 19:11:36 UTC
[jira] [Comment Edited] (SQOOP-1349) Sqoop2: Use configurable
writable to get Intermediate Data Format
[ https://issues.apache.org/jira/browse/SQOOP-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14210083#comment-14210083 ]
Veena Basavaraj edited comment on SQOOP-1349 at 11/13/14 6:11 PM:
------------------------------------------------------------------
tested [~abec] patch and some comments to the code explaining the mapper/ reader/ record writer process
It is a good enhancement done +1
was (Author: vybs):
tested your patch and some comments to the code explaining the mapper/ reader/ record writer process
> Sqoop2: Use configurable writable to get Intermediate Data Format
> -----------------------------------------------------------------
>
> Key: SQOOP-1349
> URL: https://issues.apache.org/jira/browse/SQOOP-1349
> Project: Sqoop
> Issue Type: Sub-task
> Components: sqoop2-framework
> Affects Versions: 1.99.3
> Reporter: Abraham Elmahrek
> Assignee: Veena Basavaraj
> Fix For: 1.99.5
>
> Attachments: SQOOP-1349-tested.patch, SQOOP-1349.abe.patch
>
>
> The below code performs an unnecessary string copy.
> {code}
> toDataFormat.setObjectData( matcher.getMatchingData( fromDataFormat.getObjectData() ) );
> writable.setString(toDataFormat.getTextData());
> context.write(writable, NullWritable.get());
> {code}
> It would be better to just pass IDFs around.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)