[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

["Duo Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180303#comment-17180303 ] 

Duo Zhang commented on HBASE-24898:
-----------------------------------

{quote}
Why?
{quote}

At most it can only advance the tick by one within one method call right? So if you call it every 2 hours, it can only increase the hour by one...

> Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-24898
>                 URL: https://issues.apache.org/jira/browse/HBASE-24898
>             Project: HBase
>          Issue Type: Bug
>          Components: tooling
>            Reporter: Zheng Wang
>            Assignee: Zheng Wang
>            Priority: Major
>
> The valid number in OffPeakHours is 0-23, and the end hour not included, so we can not set all hours as offpeak hour now.
> It is not useful for users in general, but useful for unit test, eg: TestStochasticLoadBalancer.testMoveCostMultiplier, in this case, the multiplier of move cost should be a lower value in offpeak, and we expect it always as offpeak hour no matter when it runs.
> My proposal is just change the valid number from 0-23 to 0-24, then we can easily apply this pr to all active branchs, and folks do not need to change them configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)