You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by br...@apache.org on 2005/08/21 07:16:32 UTC
svn commit: r234149 -
/maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
Author: brett
Date: Sat Aug 20 22:16:28 2005
New Revision: 234149
URL: http://svn.apache.org/viewcvs?rev=234149&view=rev
Log:
make sure to load extensions from all projects, not just the root in a reactor
Modified:
maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java?rev=234149&r1=234148&r2=234149&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java Sat Aug 20 22:16:28 2005
@@ -103,9 +103,9 @@
public MavenExecutionResponse execute( MavenSession session, ReactorManager rm, EventDispatcher dispatcher )
throws LifecycleExecutionException
{
- MavenProject project = rm.getTopLevelProject();
+ MavenProject rootProject = rm.getTopLevelProject();
- List taskSegments = segmentTaskListByAggregationNeeds( session.getGoals(), session, project );
+ List taskSegments = segmentTaskListByAggregationNeeds( session.getGoals(), session, rootProject );
MavenExecutionResponse response = new MavenExecutionResponse();
@@ -113,16 +113,22 @@
try
{
- for ( Iterator i = project.getBuildExtensions().iterator(); i.hasNext(); )
+ // TODO: probably don't want to do all this up front
+ for ( Iterator i = session.getSortedProjects().iterator(); i.hasNext(); )
{
- Extension extension = (Extension) i.next();
- extensionManager.addExtension( extension, project, session.getLocalRepository() );
- }
+ MavenProject project = (MavenProject) i.next();
+
+ for ( Iterator j = project.getBuildExtensions().iterator(); j.hasNext(); )
+ {
+ Extension extension = (Extension) j.next();
+ extensionManager.addExtension( extension, project, session.getLocalRepository() );
+ }
- Map handlers = findArtifactTypeHandlers( project, session.getSettings(), session.getLocalRepository() );
- artifactHandlerManager.addHandlers( handlers );
+ Map handlers = findArtifactTypeHandlers( project, session.getSettings(), session.getLocalRepository() );
+ artifactHandlerManager.addHandlers( handlers );
+ }
- executeTaskSegments( taskSegments, rm, session, project, dispatcher );
+ executeTaskSegments( taskSegments, rm, session, rootProject, dispatcher );
if ( ReactorManager.FAIL_AT_END.equals( rm.getFailureBehavior() ) && rm.hasBuildFailures() )
{
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org