You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "metalmatze (via GitHub)" <gi...@apache.org> on 2023/06/20 11:04:15 UTC
[GitHub] [arrow] metalmatze opened a new pull request, #36169: MINOR: [Go] Remove deprecated equality checks
metalmatze opened a new pull request, #36169:
URL: https://github.com/apache/arrow/pull/36169
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
There are several deprecated comparison functions that have long been deprecated.
This PR unblocks the removal of those functions as nothing depends on them anymore.
Given the functions have been deprecated for a long time and might have been removed in v9, I removed them in this PR already, given this is for v13.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
Unit tests are passing locally.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
Removal of old deprecated functions for comparing arrays.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36169: GH-36198: [Go] Remove deprecated equality checks
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36169:
URL: https://github.com/apache/arrow/pull/36169#issuecomment-1603601997
Conbench analyzed the 6 benchmark runs on commit `5854d040`.
There were 6 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-06-22 23:38:09Z](http://conbench.ursa.dev/compare/runs/30800cded8f0402298871c247f8d78d3...4f1555c057dd482c86bf44a952f7b6ab/)
- [engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-11, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/06494c7e7b3b755c8000a873fb474d0d...06494f740434752a800042055efea322)
- Commit Run on `arm64-m6g-linux-compute` at [2023-06-21 20:04:16Z](http://conbench.ursa.dev/compare/runs/90fc1415bc234b7881adeb5f09b7bd7f...c0e0b52711b94999ace7746780f022d0/)
- [params=131072/0, source=cpp-micro, suite=arrow-bit-util-benchmark](http://conbench.ursa.dev/compare/benchmarks/06493494270875b38000c8ac4044fbd1...06493580f2ed77e7800044babe9aa4e5)
- and 4 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14490448781) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36169: MINOR: [Go] Remove deprecated equality checks
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36169:
URL: https://github.com/apache/arrow/pull/36169#issuecomment-1598624899
Could you open an issue for this pull request because this is not a MINOR change?
See also our MINOR definition: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36169: GH-36198: [Go] Remove deprecated equality checks
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36169:
URL: https://github.com/apache/arrow/pull/36169#issuecomment-1600568755
:warning: GitHub issue #36198 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #36169: MINOR: [Go] Remove deprecated equality checks
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #36169:
URL: https://github.com/apache/arrow/pull/36169#issuecomment-1599096633
I agree with @kou's statement that this isn't a MINOR change and should have an issue opened for it. Also it looks like you missed one `ArrayEqual` in the `cdata_test.go` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #36169: GH-36198: [Go] Remove deprecated equality checks
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #36169:
URL: https://github.com/apache/arrow/pull/36169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] metalmatze commented on pull request #36169: MINOR: [Go] Remove deprecated equality checks
Posted by "metalmatze (via GitHub)" <gi...@apache.org>.
metalmatze commented on PR #36169:
URL: https://github.com/apache/arrow/pull/36169#issuecomment-1600567529
Thanks for pointing me to the documentation on what's a minor! :+1:
I have opened https://github.com/apache/arrow/issues/36198.
I'll push a fix for the broken `cdata/cdata_test.go` that I didn't catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org