You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2018/08/24 03:14:24 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #2343: Enhance TagRouter: modify tag router strategy

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=h1) Report
> Merging [#2343](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f720ccb965d490e6cc328af8d3e9820cb6eaf8f7?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `88.88%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/graphs/tree.svg?height=150&width=650&token=VnEIkiFQT0&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #2343      +/-   ##
============================================
- Coverage     54.84%   54.75%   -0.09%     
+ Complexity     5240     5235       -5     
============================================
  Files           573      573              
  Lines         25456    25454       -2     
  Branches       4537     4537              
============================================
- Hits          13961    13937      -24     
- Misses         9401     9420      +19     
- Partials       2094     2097       +3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...dubbo/rpc/cluster/router/tag/TagRouterFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXJGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `69.69% <88.88%> (+3.98%)` | `12 <0> (+1)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `78.57% <0%> (-7.15%)` | `10% <0%> (ø)` | |
| [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==) | `58.06% <0%> (-6.46%)` | `3% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `60% <0%> (-6.25%)` | `21% <0%> (-2%)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `68.33% <0%> (-3.34%)` | `11% <0%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2343/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=footer). Last update [f720ccb...6f59819](https://codecov.io/gh/apache/incubator-dubbo/pull/2343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2343 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org