[GitHub] [tinkerpop] BrynCooke commented on a change in pull request #1145: TINKERPOP-2243 Add userAgent to RequestOptions.

[GitBox <gi...@apache.org>]

BrynCooke commented on a change in pull request #1145: TINKERPOP-2243 Add userAgent to RequestOptions.
URL: https://github.com/apache/tinkerpop/pull/1145#discussion_r295217957
 
 

 ##########
 File path: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
 ##########
 @@ -1596,6 +1601,18 @@ public void shouldCloseAllClientsOnCloseOfCluster() throws Exception {
         cluster.close();
     }
 
+    @Test
+    public void shouldSendUserAgent() throws Exception {
 
 Review comment:
   `userAgent` is not overridable on the traversal level, it's purely a request based thing.
   It's not accessible from scripts, and is only there for graph providers who have customised their request handling to pick up this extra info.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services