You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/09/27 02:05:55 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3926: [ZEPPELIN-5061] fix note list broadcast

zjffdu commented on a change in pull request #3926:
URL: https://github.com/apache/zeppelin/pull/3926#discussion_r495516333



##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java
##########
@@ -359,6 +359,19 @@ public void unicastParagraph(Note note, Paragraph p, String user, String msgId)
     }
   }
 
+  public static abstract class UserIterator {
+    public abstract void handleUser(String user, Set<String> userAndRoles);
+  }
+
+  public void forAllUsers(UserIterator iterator) {
+    Set<String> userAndRoles;

Review comment:
       It could be moved to the for loop. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org