You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/28 04:34:20 UTC

[GitHub] [beam] youngoli commented on a change in pull request #15604: [BEAM-12973] Print Go Test and Script info to STDErr.

youngoli commented on a change in pull request #15604:
URL: https://github.com/apache/beam/pull/15604#discussion_r717215390



##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -70,7 +70,8 @@
 #        jar from the appropriate gradle module, which may not succeed.
 
 set -e
-set -v
+trap '! [[ "$BASH_COMMAND" =~ ^(echo|read|if|ARGS|shift|SOCKET_SCRIPT|\[\[) ]] && \

Review comment:
       Minor nit: A comment explaining what this line is doing would be useful, since it's pretty incomprehensible to the average reader.
   
   (It just prints all commands executed to stdout except for the lines starting with one of those commands specified up top, right? I'm guessing the "eval echo" bit is some safety checks?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org