[GitHub] [inlong] Yizhou-Yang commented on a diff in pull request #7456: [INLONG-7455][Sort] Fixing Dirty Data Archival Format Issues in Iceberg Connector

["Yizhou-Yang (via GitHub)" <gi...@apache.org>]

Yizhou-Yang commented on code in PR #7456:
URL: https://github.com/apache/inlong/pull/7456#discussion_r1119658935


##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/DynamicSchemaHandleOperator.java:
##########
@@ -314,7 +314,11 @@ private void handleSchemaInfoEvent(TableIdentifier tableId, Schema schema) {
                                 LOG.warn("Ignore table {} schema change, old: {} new: {}.",
                                         tableId, dataSchema, latestSchema, e);
                                 blacklist.add(tableId);
-                                handleDirtyData(jsonNode, jsonNode, DirtyType.EXTRACT_ROWDATA_ERROR, e, tableId);
+                                List<RowData> rowDataForDataSchemaList = dynamicSchemaFormat.extractRowData(jsonNode,

Review Comment:
   is there a possibility that this line will throw an exception? If so, is it handled properly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org