You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/06/22 00:33:50 UTC
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
From Dmitry Lychagin <dm...@gmail.com>:
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
[NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Align ConstantExpression.toString() with IAObject.toString()
for NULL and MISSING values
Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
---
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/16643/1
diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
index e9a2f2a..6f0cbba 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
@@ -129,7 +129,7 @@
@Override
public String toString() {
- return "NULL";
+ return "null";
}
@Override
@@ -166,7 +166,7 @@
@Override
public String toString() {
- return "MISSING";
+ return "missing";
}
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@gmail.com>:
Dmitry Lychagin has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
[NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Align ConstantExpression.toString() with IAObject.toString()
for NULL and MISSING values
Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
---
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved
Jenkins: Verified; ; Verified
Objections:
Anon. E. Moose #1000171: Violations found
diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
index e9a2f2a..6f0cbba 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
@@ -129,7 +129,7 @@
@Override
public String toString() {
- return "NULL";
+ return "null";
}
@Override
@@ -166,7 +166,7 @@
@Override
public String toString() {
- return "MISSING";
+ return "missing";
}
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: merged
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@gmail.com>:
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
[NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Align ConstantExpression.toString() with IAObject.toString()
for NULL and MISSING values
Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
---
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/16643/1
diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
index e9a2f2a..6f0cbba 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/ConstantExpression.java
@@ -129,7 +129,7 @@
@Override
public String toString() {
- return "NULL";
+ return "null";
}
@Override
@@ -166,7 +166,7 @@
@Override
public String toString() {
- return "MISSING";
+ return "missing";
}
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Comment-Date: Wed, 22 Jun 2022 14:31:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
Patch Set 1: Contrib+1
Graphix Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/graphix-compat/160/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Wed, 22 Jun 2022 01:01:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
Patch Set 1:
Graphix Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/graphix-compat/160/
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Wed, 22 Jun 2022 00:51:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/13216/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Wed, 22 Jun 2022 02:18:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643 )
Change subject: [NO ISSUE][COMP] Align ConstantExpression.toString() with IAObject
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/7iye6jtKmQZBotv3A : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16643
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia9a55a36f3d529836e1c24b7c22d3040b542e658
Gerrit-Change-Number: 16643
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Wed, 22 Jun 2022 00:41:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment