You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/05/25 16:21:40 UTC
[GitHub] [hadoop] amahussein opened a new pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
amahussein opened a new pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050
## NOTICE
In order to replace Guava Preconditions, we need to implement our own versions of the API.
This PR is to create `checkNotNull` in a new package dubbed `unguava`.
This is splitting the PR that was opened previously #2134
**The plan is as follows**
- create a new `package org.apache.hadoop.util.unguava`;
- create `class Validate`
- implement `org.apache.hadoop.util.unguava.Validate` with the following interface
- `checkNotNull(final T obj)`
- `checkNotNull(final T reference, final Object errorMessage)`
- `checkNotNull(final T obj, final String message, final Object... values)`
- `checkNotNull(final T obj,final Supplier<String> msgSupplier)`
- `guava.preconditions` used `String.lenientformat` which suppressed exceptions caused by string formatting of the exception message . So, in order to avoid changing the behavior, the implementation catches exceptions triggered by building the message (IllegalFormat, InsufficientArg, NullPointer..etc)
- After merging the new class, we can replace `guava.Preconditions.checkNotNull` by `unguava.Validate.checkNotNull`
- We need the change to go into trunk, 3.1, 3.2, and 3.3
Similar Jiras will be created to implement `checkState`, `checkArgument`, `checkIndex`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-921665970
> I remember you suggested in #2134 to change the package name.
my bad. Sorry for be sorry for being inconsistent. I try to remember these things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on a change in pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#discussion_r639583064
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
+ * <ul>
+ * <li>An invalid {@code null} obj causes a {@link NullPointerException}.</li>
+ * <li>An invalid argument causes an {@link IllegalArgumentException}.</li>
+ * <li>An invalid state causes an {@link IllegalStateException}.</li>
+ * <li>An invalid index causes an {@link IndexOutOfBoundsException}.</li>
+ * </ul>
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+public final class Validate {
+ public static final Logger LOG =
+ LoggerFactory.getLogger(Validate.class);
+
+ public static final String VALIDATE_IS_NOT_NULL_EX_MESSAGE =
+ "The argument object is NULL";
+
+ private Validate() {
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is
+ * "The validated object is null".</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @return the validated object
+ * @throws NullPointerException if the object is {@code null}
+ * @see #checkNotNull(Object, Object)
+ */
+ public static <T> T checkNotNull(final T obj) {
+ return checkNotNull(obj, VALIDATE_IS_NOT_NULL_EX_MESSAGE);
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is {@code errorMessage}.</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @param errorMessage the message associated with the NPE
+ * @return the validated object
+ * @throws NullPointerException if the object is {@code null}
+ * @see #checkNotNull(Object, String, Object...)
+ */
+ public static <T> T checkNotNull(final T obj,
+ final Object errorMessage) {
+ if (obj == null) {
+ throw new NullPointerException(String.valueOf(errorMessage));
+ }
+ return obj;
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is {@code String.format(f, m)}.</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @param message the {@link String#format(String, Object...)}
+ * exception message if valid. Otherwise,
+ * the message is {@link #VALIDATE_IS_NOT_NULL_EX_MESSAGE}
+ * @param values the optional values for the formatted exception message
+ * @return the validated object
+ * @throws NullPointerException if the object is {@code null}
+ * @see #checkNotNull(Object, Supplier)
+ */
+ public static <T> T checkNotNull(final T obj, final String message,
+ final Object... values) {
+ // Deferring the evaluation of the message is a tradeoff between the cost
+ // of constructing lambda vs constructing a string object.
+ // Using lambda would allocate an object on every all:
+ // return checkNotNull(obj, () -> String.format(message, values));
+ if (obj == null) {
+ String msg = VALIDATE_IS_NOT_NULL_EX_MESSAGE;
+ try {
+ msg = String.format(message, values);
+ } catch (Exception e) {
+ LOG.debug("Error formatting message: {}", e.getMessage());
Review comment:
As it is already at DEBUG level, do we also want to print stacktrace by providing `e` as last argument? Perhaps for some hidden case, it might provide good visibility at DEBUG level.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
+ * <ul>
+ * <li>An invalid {@code null} obj causes a {@link NullPointerException}.</li>
+ * <li>An invalid argument causes an {@link IllegalArgumentException}.</li>
+ * <li>An invalid state causes an {@link IllegalStateException}.</li>
+ * <li>An invalid index causes an {@link IndexOutOfBoundsException}.</li>
+ * </ul>
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+public final class Validate {
+ public static final Logger LOG =
+ LoggerFactory.getLogger(Validate.class);
+
+ public static final String VALIDATE_IS_NOT_NULL_EX_MESSAGE =
Review comment:
nit: we can keep default package private scope.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
+ * <ul>
+ * <li>An invalid {@code null} obj causes a {@link NullPointerException}.</li>
+ * <li>An invalid argument causes an {@link IllegalArgumentException}.</li>
+ * <li>An invalid state causes an {@link IllegalStateException}.</li>
+ * <li>An invalid index causes an {@link IndexOutOfBoundsException}.</li>
+ * </ul>
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+public final class Validate {
+ public static final Logger LOG =
Review comment:
nit: `private` would be better
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
+ * <ul>
+ * <li>An invalid {@code null} obj causes a {@link NullPointerException}.</li>
+ * <li>An invalid argument causes an {@link IllegalArgumentException}.</li>
+ * <li>An invalid state causes an {@link IllegalStateException}.</li>
+ * <li>An invalid index causes an {@link IndexOutOfBoundsException}.</li>
+ * </ul>
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+public final class Validate {
+ public static final Logger LOG =
+ LoggerFactory.getLogger(Validate.class);
+
+ public static final String VALIDATE_IS_NOT_NULL_EX_MESSAGE =
+ "The argument object is NULL";
+
+ private Validate() {
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is
+ * "The validated object is null".</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @return the validated object
+ * @throws NullPointerException if the object is {@code null}
+ * @see #checkNotNull(Object, Object)
+ */
+ public static <T> T checkNotNull(final T obj) {
+ return checkNotNull(obj, VALIDATE_IS_NOT_NULL_EX_MESSAGE);
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is {@code errorMessage}.</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @param errorMessage the message associated with the NPE
+ * @return the validated object
+ * @throws NullPointerException if the object is {@code null}
+ * @see #checkNotNull(Object, String, Object...)
+ */
+ public static <T> T checkNotNull(final T obj,
+ final Object errorMessage) {
+ if (obj == null) {
+ throw new NullPointerException(String.valueOf(errorMessage));
+ }
+ return obj;
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is {@code String.format(f, m)}.</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @param message the {@link String#format(String, Object...)}
+ * exception message if valid. Otherwise,
+ * the message is {@link #VALIDATE_IS_NOT_NULL_EX_MESSAGE}
+ * @param values the optional values for the formatted exception message
+ * @return the validated object
+ * @throws NullPointerException if the object is {@code null}
+ * @see #checkNotNull(Object, Supplier)
+ */
+ public static <T> T checkNotNull(final T obj, final String message,
+ final Object... values) {
+ // Deferring the evaluation of the message is a tradeoff between the cost
+ // of constructing lambda vs constructing a string object.
+ // Using lambda would allocate an object on every all:
+ // return checkNotNull(obj, () -> String.format(message, values));
+ if (obj == null) {
+ String msg = VALIDATE_IS_NOT_NULL_EX_MESSAGE;
+ try {
+ msg = String.format(message, values);
+ } catch (Exception e) {
+ LOG.debug("Error formatting message: {}", e.getMessage());
+ }
+ throw new NullPointerException(msg);
+ }
+ return obj;
+ }
+
+ /**
+ * <p>Validate that the specified argument is not {@code null},
+ * throwing a NPE exception otherwise.
+ *
+ * <p>The message of the exception is {@code msgSupplier.get()}.</p>
+ *
+ * @param <T> the object type
+ * @param obj the object to check
+ * @param msgSupplier the {@link Supplier#get()} set the
+ * exception message if valid. Otherwise,
+ * the message is {@link #VALIDATE_IS_NOT_NULL_EX_MESSAGE}
+ * @return the validated object (never {@code null} for method chaining)
+ * @throws NullPointerException if the object is {@code null}
+ */
+ public static <T> T checkNotNull(final T obj,
+ final Supplier<String> msgSupplier) {
+ if (obj == null) {
+ String msg = VALIDATE_IS_NOT_NULL_EX_MESSAGE;
+ try {
+ // note that we can get NPE evaluating the message itself;
+ // but we do not want this to override the actual NPE.
+ msg = msgSupplier.get();
+ } catch (Exception e) {
+ // ideally we want to log the error to capture. This may cause log files
+ // to bloat. On the other hand, swallowing the exception may hide a bug
+ // in the caller. Debug level is a good compromise between the two
+ // concerns.
+ LOG.debug("Error formatting message: {}", e.getMessage());
+ }
Review comment:
nit: This one is fine, but how about single assignment? (only if you feel this one is good to use)
```
String msg;
try {
// note that we can get NPE evaluating the message itself;
// but we do not want this to override the actual NPE.
msg = msgSupplier.get();
} catch (Exception e) {
msg = VALIDATE_IS_NOT_NULL_EX_MESSAGE;
// ideally we want to log the error to capture. This may cause log files
// to bloat. On the other hand, swallowing the exception may hide a bug
// in the caller. Debug level is a good compromise between the two
// concerns.
LOG.debug("Error formatting message: {}", e.getMessage());
}
```
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
Review comment:
With this, good to mention: Javadocs for majority of APIs in this class are taken from which Guava release version.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
+ * <ul>
+ * <li>An invalid {@code null} obj causes a {@link NullPointerException}.</li>
+ * <li>An invalid argument causes an {@link IllegalArgumentException}.</li>
+ * <li>An invalid state causes an {@link IllegalStateException}.</li>
+ * <li>An invalid index causes an {@link IndexOutOfBoundsException}.</li>
+ * </ul>
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+public final class Validate {
Review comment:
If we keep the same name i.e `Preconditions`, only import will require changes in follow-up PRs and it would look clean.
Given that `Preconditions` is heavily used in the code base, from change as well as review perspectives, it will be much cleaner. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran closed pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
steveloughran closed pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-921899866
1. I've merged this in to trunk, branch-3.3 and branch-3.2, with a retest on each backport.
2. and going to close it as done
now, for the rest of the hadoop-common JIRA, should we create a new JIRA for that and mark the current one as closed (with versions)? I think it'd be best for tracking like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] amahussein commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
amahussein commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-921055717
@steveloughran This PR was one of the steps to replace the guava dependency in common module.
Can you please take a look? I remember you suggested in #2134 to change the package name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] amahussein commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
amahussein commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-849699615
@busbey Can you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-848198192
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 12s | | trunk passed |
| +1 :green_heart: | compile | 20m 51s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 18m 9s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 8s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 35s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 37s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 24s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 44s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 54s | | the patch passed |
| +1 :green_heart: | compile | 20m 10s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 20m 10s | | the patch passed |
| +1 :green_heart: | compile | 18m 3s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 18m 3s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 6s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 7s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 35s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 3s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 15s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not generate ASF License warnings. |
| | | 179m 33s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3050 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux ee539af4493d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / aa10cd26b10455cb6fc6fc8cc9d74e683dfca38c |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/1/testReport/ |
| Max. process+thread count | 1649 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] amahussein commented on a change in pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
amahussein commented on a change in pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#discussion_r639900657
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
Review comment:
I did not copy the code from guava; but I see your point.
It is going to be helpful to have that added to some APIs. I will review the APIs and see which ones need this info added to their Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#discussion_r710920568
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Preconditions.java
##########
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting;
Review comment:
Do we need this? It makes backporting this patch on its own harder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-849063289
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 21s | | trunk passed |
| +1 :green_heart: | compile | 26m 31s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 18m 15s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 8s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 39s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 24s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 50s | | branch has no errors when building and testing our client artifacts. |
| -0 :warning: | patch | 16m 13s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 53s | | the patch passed |
| +1 :green_heart: | compile | 20m 7s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 20m 7s | | the patch passed |
| +1 :green_heart: | compile | 18m 14s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 18m 14s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 7s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/2/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | mvnsite | 1m 35s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 6s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 34s | | the patch passed |
| +1 :green_heart: | shadedclient | 15m 55s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 5s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not generate ASF License warnings. |
| | | 184m 40s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3050 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a51c2ef024b2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f7af46c3dbc5d242acd45bafed498008dae8c5f4 |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/2/testReport/ |
| Max. process+thread count | 1280 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] amahussein commented on a change in pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
amahussein commented on a change in pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#discussion_r639805392
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Validate.java
##########
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+
+/**
+ * <p>This class replaces {@code guava.Preconditions} which provides helpers
+ * to validate the following conditions:
+ * <ul>
+ * <li>An invalid {@code null} obj causes a {@link NullPointerException}.</li>
+ * <li>An invalid argument causes an {@link IllegalArgumentException}.</li>
+ * <li>An invalid state causes an {@link IllegalStateException}.</li>
+ * <li>An invalid index causes an {@link IndexOutOfBoundsException}.</li>
+ * </ul>
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+public final class Validate {
Review comment:
Sounds like a good idea. I will rename the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#issuecomment-849180097
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 7s | | trunk passed |
| +1 :green_heart: | compile | 20m 54s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 18m 11s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 9s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 37s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 27s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 40s | | branch has no errors when building and testing our client artifacts. |
| -0 :warning: | patch | 16m 3s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 54s | | the patch passed |
| +1 :green_heart: | compile | 20m 15s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 20m 15s | | the patch passed |
| +1 :green_heart: | compile | 18m 17s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 18m 17s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 7s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/3/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | mvnsite | 1m 34s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 7s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 41s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 35s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 8s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 14s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not generate ASF License warnings. |
| | | 180m 18s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3050 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 32e862d606c5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 0a460a4e731b1e2d3e35db33cd33f2ebd47f4965 |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/3/testReport/ |
| Max. process+thread count | 3062 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3050/3/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on a change in pull request #3050: HADOOP-17126. implement non-guava Precondition checkNotNull
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3050:
URL: https://github.com/apache/hadoop/pull/3050#discussion_r710923661
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Preconditions.java
##########
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.util;
+
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting;
Review comment:
This reminds me of the decision HBase community made sometime back to remove usage of VisibleForTesting entirely from the codebase and replaced them with IA.Private. Here is the [commit](https://github.com/apache/hbase/commit/1726160839368df14602da1618e3538955b25f74)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org