You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/06 10:12:08 UTC

[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3693: [refactor] [server] Refactor ByteBuf release method in module distributedlog-core/distributedlog-protocol

StevenLuMT opened a new pull request, #3693:
URL: https://github.com/apache/bookkeeper/pull/3693

   ### Motivation
   
   It may throw an exception when release a ByteBuf object. so the exception in ByteBuf.release should be checked.
   
   ### Changes
   1) Use ReferenceCountUtil.safeRelease() instead of ByteBuf.release() in module distributedlog-core/distributedlog-protocol
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3693: [refactor] [server] Refactor ByteBuf release method in module distributedlog-core/distributedlog-protocol

Posted by GitBox <gi...@apache.org>.

StevenLuMT commented on PR #3693:
URL: https://github.com/apache/bookkeeper/pull/3693#issuecomment-1340313010

   > @StevenLuMT Please do not tag `cherry-picked/xx` on Prs, which is not cherry-picked to the target branch.
   
   Got it ,thanks @hangc0276 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3693: [refactor] [server] Refactor ByteBuf release method in module distributedlog-core/distributedlog-protocol

Posted by GitBox <gi...@apache.org>.

hangc0276 commented on PR #3693:
URL: https://github.com/apache/bookkeeper/pull/3693#issuecomment-1340260711

   @StevenLuMT Please do not tag `cherry-picked/xx` on Prs, which is not cherry-picked to the target branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT merged pull request #3693: [refactor] [server] Refactor ByteBuf release method in module distributedlog-core/distributedlog-protocol

Posted by GitBox <gi...@apache.org>.

StevenLuMT merged PR #3693:
URL: https://github.com/apache/bookkeeper/pull/3693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org