You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2026/04/16 05:19:28 UTC
[PR] test(java/driver/jni): add tests with drivers besides SQLite [arrow-adbc]
lidavidm opened a new pull request, #4235:
URL: https://github.com/apache/arrow-adbc/pull/4235
Closes #4230.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(java/driver/jni): add tests with drivers besides SQLite [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4235:
URL: https://github.com/apache/arrow-adbc/pull/4235#discussion_r3127292311
##########
.github/workflows/java.yml:
##########
@@ -228,10 +228,34 @@ jobs:
done
popd
cp -r artifacts/*/jni/adbc_driver_jni java/driver/jni/src/main/resources
+ env BUILD_JNI=ON ./ci/scripts/java_build.sh $(pwd)
+
+ - name: Start Dependencies
+ if: matrix.os == 'Linux' && matrix.arch == 'amd64'
+ run: |
+ docker compose up --detach --wait mssql-test postgres-test
+ cat .env | grep -v -e '^#' | grep -e '^ADBC_' | awk NF | sed 's/"//g' | tee -a $GITHUB_ENV
+
+ - name: Download thirdparty driver
+ if: matrix.os == 'Linux' && matrix.arch == 'amd64'
+ run: |
+ wget https://dbc-cdn.columnar.tech/mssql/v1.3.1/mssql_linux_amd64_v1.3.1.tar.gz
+ echo "e6723cf417403f313fb75c1ac03aea9b9ff857d4a947608c8ae44eacc1aa22b3 mssql_linux_amd64_v1.3.1.tar.gz" > mssql_linux_amd64_v1.3.1.tar.gz.sha256
+ sha256sum -c mssql_linux_amd64_v1.3.1.tar.gz.sha256
+
+ tar xvf mssql_linux_amd64_v1.3.1.tar.gz
+ mkdir -p ~/.config/adbc/drivers/
+ mv libadbc_driver_mssql.so ~/.config/adbc/drivers/
+ echo "manifest_version = 1" > ~/.config/adbc/drivers/mssql.toml
+ echo "[Driver]" >> ~/.config/adbc/drivers/mssql.toml
+ echo "shared = '$HOME/.config/adbc/drivers/libadbc_driver_mssql.so'" >> ~/.config/adbc/drivers/mssql.toml
+ cat ~/.config/adbc/drivers/mssql.toml
Review Comment:
Nah, I'm trying to minimize external dependencies here. Also I want to pin a particular hash since it's an external binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(java/driver/jni): add tests with drivers besides SQLite [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #4235:
URL: https://github.com/apache/arrow-adbc/pull/4235#discussion_r3125193466
##########
.github/workflows/java.yml:
##########
@@ -228,10 +228,34 @@ jobs:
done
popd
cp -r artifacts/*/jni/adbc_driver_jni java/driver/jni/src/main/resources
+ env BUILD_JNI=ON ./ci/scripts/java_build.sh $(pwd)
+
+ - name: Start Dependencies
+ if: matrix.os == 'Linux' && matrix.arch == 'amd64'
+ run: |
+ docker compose up --detach --wait mssql-test postgres-test
+ cat .env | grep -v -e '^#' | grep -e '^ADBC_' | awk NF | sed 's/"//g' | tee -a $GITHUB_ENV
+
+ - name: Download thirdparty driver
+ if: matrix.os == 'Linux' && matrix.arch == 'amd64'
+ run: |
+ wget https://dbc-cdn.columnar.tech/mssql/v1.3.1/mssql_linux_amd64_v1.3.1.tar.gz
+ echo "e6723cf417403f313fb75c1ac03aea9b9ff857d4a947608c8ae44eacc1aa22b3 mssql_linux_amd64_v1.3.1.tar.gz" > mssql_linux_amd64_v1.3.1.tar.gz.sha256
+ sha256sum -c mssql_linux_amd64_v1.3.1.tar.gz.sha256
+
+ tar xvf mssql_linux_amd64_v1.3.1.tar.gz
+ mkdir -p ~/.config/adbc/drivers/
+ mv libadbc_driver_mssql.so ~/.config/adbc/drivers/
+ echo "manifest_version = 1" > ~/.config/adbc/drivers/mssql.toml
+ echo "[Driver]" >> ~/.config/adbc/drivers/mssql.toml
+ echo "shared = '$HOME/.config/adbc/drivers/libadbc_driver_mssql.so'" >> ~/.config/adbc/drivers/mssql.toml
+ cat ~/.config/adbc/drivers/mssql.toml
Review Comment:
use `setup-dbc` and use dbc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(java/driver/jni): add tests with drivers besides SQLite [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4235:
URL: https://github.com/apache/arrow-adbc/pull/4235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org