You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/10 15:37:27 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4678: Support mutiple management networks in systemvms
ravening opened a new pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678
### Description
Currently only one management.network.cidr is suuported in systemvms
Allow supporting comma separated list of cidr's so that multiple
networks are reachable from systemvms.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1044524532
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1044368509
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#discussion_r678952401
##########
File path: systemvm/debian/opt/cloud/bin/setup/common.sh
##########
@@ -322,7 +322,12 @@ setup_common() {
if [ -n "$MGMTNET" -a -n "$LOCAL_GW" ]
then
- ip route add $MGMTNET via $LOCAL_GW dev eth1
+ log_it "Received mgmt cidr : $MGMTNET"
+ cidrs=(${MGMTNET//,/ })
+ for cidr in ${cidrs[@]}
+ do
+ ip route add $cidr dev eth1
Review comment:
> @ravening I am wondering why there is no "via gateway" in route.
@weizhouapache do we need the "via gateway" ? it was not there in the original change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1044292223
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1043777704
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#discussion_r659346639
##########
File path: systemvm/debian/opt/cloud/bin/setup/common.sh
##########
@@ -322,7 +322,12 @@ setup_common() {
if [ -n "$MGMTNET" -a -n "$LOCAL_GW" ]
then
- ip route add $MGMTNET via $LOCAL_GW dev eth1
+ log_it "Received mgmt cidr : $MGMTNET"
+ cidrs=(${MGMTNET//,/ })
+ for cidr in ${cidrs[@]}
+ do
+ ip route add $cidr dev eth1
Review comment:
> @ravening I am wondering why there is no "via gateway" in route.
@ravening any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-919837232
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-921059325
<b>Trillian test result (tid-2079)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42682 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t2079-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-889876900
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-889780034
<b>Trillian test result (tid-1414)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 74119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t1414-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3612.97 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3611.12 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 93.19 | test_kubernetes_clusters.py
test_04_create_template_with_checksum_md5 | `Error` | 65.66 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.60 | test_templates.py
test_03_delete_template | `Error` | 298.42 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.03 | test_templates.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 544.01 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 366.70 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-914913803
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-919214736
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1043778976
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-920562792
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-914961912
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-889032568
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-870339234
ping @ravening any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-890282644
<b>Trillian test result (tid-1433)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t1433-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 113.97 | test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 392.58 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 547.46 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 465.35 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 560.92 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 361.02 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-930013263
> Ping @ravening can you check the open comment on the script file?
@nvazquez @weizhouapache made the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1044291206
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1044523324
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1043838319
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 2650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-920562333
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-914914073
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-921182251
Ping @ravening can you check the open comment on the script file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-919261446
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#discussion_r574041199
##########
File path: systemvm/debian/opt/cloud/bin/setup/common.sh
##########
@@ -322,7 +322,12 @@ setup_common() {
if [ -n "$MGMTNET" -a -n "$LOCAL_GW" ]
then
- ip route add $MGMTNET via $LOCAL_GW dev eth1
+ log_it "Received mgmt cidr : $MGMTNET"
+ cidrs=(${MGMTNET//,/ })
+ for cidr in ${cidrs[@]}
+ do
+ ip route add $cidr dev eth1
Review comment:
@ravening I am wondering why there is no "via gateway" in route.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-919213718
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-919814416
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#discussion_r709743251
##########
File path: systemvm/debian/opt/cloud/bin/setup/common.sh
##########
@@ -322,7 +322,12 @@ setup_common() {
if [ -n "$MGMTNET" -a -n "$LOCAL_GW" ]
then
- ip route add $MGMTNET via $LOCAL_GW dev eth1
+ log_it "Received mgmt cidr : $MGMTNET"
+ cidrs=(${MGMTNET//,/ })
+ for cidr in ${cidrs[@]}
+ do
+ ip route add $cidr dev eth1
Review comment:
@ravening the original line contained it (`ip route add $MGMTNET via $LOCAL_GW dev eth1`), can you explain why is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-1045280372
<b>Trillian test result (tid-3390)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31258 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4678-t3390-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-919814759
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-889877508
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-888933972
> ping @ravening any update?
@rhtyd resolved conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-930013263
> Ping @ravening can you check the open comment on the script file?
@nvazquez @weizhouapache made the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4678: Support mutiple management networks in systemvms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#issuecomment-870339234
ping @ravening any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org