You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/01 23:39:35 UTC
[Impala-ASF-CR] IMPALA-4643: [DOCS] Genericize HBase topic, esp links
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5858
Change subject: IMPALA-4643: [DOCS] Genericize HBase topic, esp links
......................................................................
IMPALA-4643: [DOCS] Genericize HBase topic, esp links
The Impala + HBase page included a little Cloudera-specific wording,
i.e. "Cloudera recommends...".
The main Cloudera-specific details were links to HBase documentation
hosted on cloudera.com. I made those links use the keydef/keyref
indirection mechanism and edited the URLs to point to the upstream
Apache HBase docs.
Centralizing these links also makes the Impala + HBase source cleaner,
because the link text doesn't need to be inside an <xref>...</xref>
pair on the page itself. The link ends up being just
"See <xref keyref="whatever"/>".
After this change, there's no more 'Cloudera' visible in the text of
the relevant HTML page, including the 'view source' view. (Previously,
the cloudera.com links would have shown up but only findable via
'view source'.
Change-Id: Ic36ad02766a0f8945759c698fa1c5760dc12d0cb
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_hbase.xml
2 files changed, 15 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/5858/1
--
To view, visit http://gerrit.cloudera.org:8080/5858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic36ad02766a0f8945759c698fa1c5760dc12d0cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Genericize HBase topic, esp links
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Genericize HBase topic, esp links
......................................................................
Patch Set 1:
Forgot to mention in the commit message: I also removed some Cloudera-specific wording and directory names that were shown in the banner messages of hive and impala-shell commands in examples.
--
To view, visit http://gerrit.cloudera.org:8080/5858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36ad02766a0f8945759c698fa1c5760dc12d0cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Genericize HBase topic, esp links
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has abandoned this change.
Change subject: IMPALA-4643: [DOCS] Genericize HBase topic, esp links
......................................................................
Abandoned
Abandoning in favor of https://gerrit.cloudera.org/#/c/5900/
--
To view, visit http://gerrit.cloudera.org:8080/5858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic36ad02766a0f8945759c698fa1c5760dc12d0cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>