You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/10/02 15:45:01 UTC
Review Request 38953: Credential Resource API should return an empty
list rather than a 404 error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38953/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
Bugs: AMBARI-13296
https://issues.apache.org/jira/browse/AMBARI-13296
Repository: ambari
Description
-------
When no credentials resources are found when listing credential resources via the Credential Resource API, an empty list should be returned rather than a 404 error.
For example:
```
GET /api/v1/clusters/c1/credentials
{
"href": "http://host:port/api/v1/clusters/c1/credentials",
"items": []
}
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 55f26a0
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 04ce22a
Diff: https://reviews.apache.org/r/38953/diff/
Testing
-------
Manually tested in cluster
# Local test results: PASSED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53:20.919s
[INFO] Finished at: Fri Oct 02 09:27:37 EDT 2015
[INFO] Final Memory: 67M/1192M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 38953: Credential Resource API should return an
empty list rather than a 404 error
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38953/#review101318
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Oct. 2, 2015, 9:45 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38953/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 9:45 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
>
>
> Bugs: AMBARI-13296
> https://issues.apache.org/jira/browse/AMBARI-13296
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When no credentials resources are found when listing credential resources via the Credential Resource API, an empty list should be returned rather than a 404 error.
>
> For example:
> ```
> GET /api/v1/clusters/c1/credentials
>
> {
> "href": "http://host:port/api/v1/clusters/c1/credentials",
> "items": []
> }
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 55f26a0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 04ce22a
>
> Diff: https://reviews.apache.org/r/38953/diff/
>
>
> Testing
> -------
>
> Manually tested in cluster
>
> # Local test results: PASSED
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53:20.919s
> [INFO] Finished at: Fri Oct 02 09:27:37 EDT 2015
> [INFO] Final Memory: 67M/1192M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 38953: Credential Resource API should return an
empty list rather than a 404 error
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38953/#review101326
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Oct. 2, 2015, 1:45 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38953/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 1:45 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
>
>
> Bugs: AMBARI-13296
> https://issues.apache.org/jira/browse/AMBARI-13296
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When no credentials resources are found when listing credential resources via the Credential Resource API, an empty list should be returned rather than a 404 error.
>
> For example:
> ```
> GET /api/v1/clusters/c1/credentials
>
> {
> "href": "http://host:port/api/v1/clusters/c1/credentials",
> "items": []
> }
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java 55f26a0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 04ce22a
>
> Diff: https://reviews.apache.org/r/38953/diff/
>
>
> Testing
> -------
>
> Manually tested in cluster
>
> # Local test results: PASSED
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53:20.919s
> [INFO] Finished at: Fri Oct 02 09:27:37 EDT 2015
> [INFO] Final Memory: 67M/1192M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>