[jira] [Commented] (COUCHDB-2206) Changes UI update

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956819#comment-13956819 ] 

ASF GitHub Bot commented on COUCHDB-2206:
-----------------------------------------

Github user deathbearbrown commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/202#discussion_r11172077
  
    --- Diff: src/fauxton/app/addons/documents/templates/changes.html ---
    @@ -12,27 +12,57 @@
     the License.
     -->
     
    -<table id="changes-table" class="table">
    -  <thead>
    -    <th id="seq"> seq </th>
    -    <th> id </th>
    -    <th id="changes"> changes </th>
    -    <th id="deleted"> deleted? </th>
    -  </thead>
    -  <tbody>
    -  <% _.each(changes, function (change) { %>
    -    <tr>
    -      <td> <%= change.seq %> </td>
    -      <% if (change.deleted) { %>
    -        <td> <%= change.id %> </td>
    -      <% } else { %>
    -        <td> <a href="#<%= database.url('app') %>/<%= change.id %>"><%= change.id %></a> </td>
    -      <% } %>
    -        <td> 
    -          <pre class="prettyprint">  <%- JSON.stringify({changes: change.changes, doc: change.doc}, null, " ") %> </pre>
    -      </td>
    -      <td><%= change.deleted ? "true" : "false" %></td>
    -    </tr>
    -  <% }); %>
    -  </tbody>
    -</table>
    +<% _.each(changes, function (change) { %>
    +  <div class="change-wrapper">
    +    <div class="change-box">
    +      <div class="row-fluid">
    +        <div class="span2">
    +          seq
    +        </div>
    +        <div class="span8">
    +          <%= change.seq %>
    +        </div>
    +        <div class="span2">
    +          <a class="js-copy" data-clipboard-text="<%= change.seq %>" data-bypass="true" href="#">
    +            <i class="icon-share"></i>
    +          </a>
    +        </div>
    +      </div>
    +      <div class="row-fluid">
    +        <div class="span2">
    +          id
    +        </div>
    +        <div class="span8">
    +          <% if (change.deleted) { %>
    +            <%= change.id %>
    +          <% } else { %>
    +            <a href="#<%= database.url('app') %>/<%= change.id %>"><%= change.id %></a>
    --- End diff --
    
    Hi!  the change.id needs to be urlencoded like this:
    #/database/demovolcano/_design%2Fimpress-ca
    
    People can name docs like this "slash///slashy/slashy/slash" and sometimes they do. 
    
    If you rebase master in, I added a helper.js function  (we put template functions in helper.js)  so you can do 
    safeURL(change.id)  and it'll check to see if the id needs to be encoded. 


> Changes UI update
> -----------------
>
>                 Key: COUCHDB-2206
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2206
>             Project: CouchDB
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Sue Lockwood
>            Assignee: Robert Kowalski
>         Attachments: Screen Shot 2014-03-22 at 9.46.15 AM.png, Screen Shot 2014-03-22 at 9.46.38 AM.png
>
>
> The changes UI needs some serious love. 
> The new UI improvements are being broken down into parts so that we can get them into master easier.  I have screenshots of just what the changes page UI should look like. 
> I cropped out the sidebar and header for now, since those changes are being made in a different branch and are used all over the site. They should be in soon. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)