[GitHub] Tibor17 commented on a change in pull request #197: SUREFIRE-1588 Patch (Java7)

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#discussion_r230358750
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -114,7 +115,7 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull String startCl
             {
                 File file1 = new File( it.next() );
 
-                String uri = parent.relativize( file1.toPath() ).toString();
+                String uri = URI.create( parent.relativize( file1.toPath() ).toString() ).toASCIIString();
 
 Review comment:
   Works for me but the annoying are logs because we log every Jar file.
   This can be fixed by using a boolean flag preventing from repeative logs with same message.
   Can you segregate the try-catch to a private method?
   I have a question regarding the bug. The build plugin crashed with plugin version `2.22.1` on 1.8.0_192? It did not crash on my Windows system. It is different experience on Linux?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services