You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ma...@apache.org on 2015/09/07 04:09:21 UTC
incubator-kylin git commit: KYLIN-991 bug fix
Repository: incubator-kylin
Updated Branches:
refs/heads/0.8 0eddcf5a8 -> b817dc25e
KYLIN-991 bug fix
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/b817dc25
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/b817dc25
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/b817dc25
Branch: refs/heads/0.8
Commit: b817dc25ef258f0e25ea2c9cbbb7835e7b5cd5fa
Parents: 0eddcf5
Author: honma <ho...@ebay.com>
Authored: Mon Sep 7 10:11:24 2015 +0800
Committer: honma <ho...@ebay.com>
Committed: Mon Sep 7 10:11:24 2015 +0800
----------------------------------------------------------------------
.../kylin/job/hadoop/cube/StorageCleanupJob.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/b817dc25/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java b/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
index 489b9ed..d83e455 100644
--- a/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
+++ b/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
@@ -18,6 +18,11 @@
package org.apache.kylin.job.hadoop.cube;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
import org.apache.commons.cli.Option;
import org.apache.commons.cli.OptionBuilder;
import org.apache.commons.cli.Options;
@@ -48,11 +53,6 @@ import org.apache.kylin.metadata.realization.IRealizationConstants;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-
/**
* @author ysong1
*/
@@ -114,8 +114,9 @@ public class StorageCleanupJob extends AbstractHadoopJob {
String creationTime = desc.getValue(IRealizationConstants.HTableCreationTime);
if (KylinConfig.getInstanceFromEnv().getMetadataUrlPrefix().equalsIgnoreCase(host)) {
//only take care htables that belongs to self, and created more than 2 days
- if (StringUtils.isNotEmpty(creationTime) || (System.currentTimeMillis() - Long.valueOf(creationTime) > TIME_THREADSHOLD))
+ if (StringUtils.isEmpty(creationTime) || (System.currentTimeMillis() - Long.valueOf(creationTime) > TIME_THREADSHOLD)) {
allTablesNeedToBeDropped.add(desc.getTableName().getNameAsString());
+ }
}
}