You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "YongGang (via GitHub)" <gi...@apache.org> on 2023/11/01 17:41:48 UTC

[PR] Distinguish between terminal compaction failures and intermittent failures (druid)

YongGang opened a new pull request, #15303:
URL: https://github.com/apache/druid/pull/15303

   ### Description
   
   This PR addresses the need for better monitoring of compaction task failures by introducing two new metrics:
   
   `task/failed/acquireLock/count`: Tracks the number of times a compaction task fails to acquire a lock. This metric is useful for identifying transient issues, such as conflicts with other ingestion jobs. To filter compaction tasks, look for group id starting with `coordinator-issued_compact`
   
   `compact/failed/schemaError/count`: Monitors the number of compaction failures due to schema mismatches within the same interval. This metric requires user intervention for resolution.
   
   By adding these metrics, we aim to provide more granular insights into the different types of compaction failures, enabling quicker diagnosis and resolution.
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
    - Method organization and design (how the logic is split between methods, parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
   
   #### Release note
   <!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users. 
   
   If your change doesn't have end user impact, you can skip this section.
   
   For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
   
   -->
   Added two new metrics `task/failed/acquireLock/count` and `compact/failed/schemaError/count` for monitoring compaction failures.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `LockAcquisitionFailedException` indicate that a lock acquisition has failed
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Distinguish between terminal compaction failures and intermittent failures (druid)

Posted by "YongGang (via GitHub)" <gi...@apache.org>.
YongGang commented on PR #15303:
URL: https://github.com/apache/druid/pull/15303#issuecomment-1804253788

   Close this for now as we may do this in a different way


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Distinguish between terminal compaction failures and intermittent failures (druid)

Posted by "YongGang (via GitHub)" <gi...@apache.org>.
YongGang closed pull request #15303: Distinguish between terminal compaction failures and intermittent failures
URL: https://github.com/apache/druid/pull/15303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Distinguish between terminal compaction failures and intermittent failures (druid)

Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #15303:
URL: https://github.com/apache/druid/pull/15303#issuecomment-1790174459

   This is not a good metric name. If a task can fail for 10 reasons, we don't have to add 10 different metrics. The right way to do is to through one metric and adding a dimension to denote the failure reason. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org