You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by amihalik <gi...@git.apache.org> on 2016/03/03 00:43:57 UTC
[GitHub] incubator-rya pull request: RYA-7 Applying Correct License
GitHub user amihalik opened a pull request:
https://github.com/apache/incubator-rya/pull/25
RYA-7 Applying Correct License
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amihalik/incubator-rya develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 5c526e698bdfa761a9c83bc034314ac3f7803a7b
Author: Aaron Mihalik <mi...@alum.mit.edu>
Date: 2016-03-02T23:37:28Z
RYA-7 Applying Correct License
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 Applying Correct License
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the pull request:
https://github.com/apache/incubator-rya/pull/25#issuecomment-191694535
Thanks @joshelser, but I need a bit more help.
I don't quite understand the apache-rat behavior. We have those exclusions in the parent pom, we have apache-rat check enabled by default, and everything works as expected if we do a `mvn clean install` (i.e. the exclusions are propagagted to the submodules). However those exclusions aren't propagated if we do a `mvn apache-rat:check`. Should I manually cut-and-paste those exclusions to the submodules?
Secondly, I don't understand why apache-rat didn't catch the "Copyright Rya" in these two files. (And I really don't understand how you caught that either :) ). Is there a more stringent setting for apache-rat?
Thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 Applying Correct License
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the pull request:
https://github.com/apache/incubator-rya/pull/25#issuecomment-192046091
gotcha, thanks! I'll put in another issue to set the configuration in each sub-module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 Applying Correct License
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the pull request:
https://github.com/apache/incubator-rya/pull/25#issuecomment-191813364
> We have those exclusions in the parent pom, we have apache-rat check enabled by default, and everything works as expected if we do a mvn clean install (i.e. the exclusions are propagagted to the submodules).
Oh interesting. I assume you mean that the apache-rat check is running with the `mvn clean install`? It could just be a configuration issue.
> However those exclusions aren't propagated if we do a mvn apache-rat:check
IIRC, you should really set the configuration in each sub-module. There are defaults (such as target/) which are automatically included via the apache parent pom, but it's good practice to localize any exclusions to the rat check in the sub-modules (to avoid unexpected exclusions). I can try to help you out with this if you get stuck.
> I don't understand why apache-rat didn't catch the "Copyright Rya" in these two files. (And I really don't understand how you caught that either :) ). Is there a more stringent setting for apache-rat?
I just grep'ed for Copyright. The license header might have been close enough to the ASL that it passed the RAT check, but I was more looking for places where you had copyrights listed (the rules are that you don't include a copyright for ASF-owned code).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 Applying Correct License
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik closed the pull request at:
https://github.com/apache/incubator-rya/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: RYA-7 Applying Correct License
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the pull request:
https://github.com/apache/incubator-rya/pull/25#issuecomment-191501007
Looks like that was the bad license headers I found. Thanks for grabbing those.
If you want to get Rya into a good place going forward, I'd recommend also getting `mvn apache-rat:check` to run without errors. I stepped through it (just removing the offending files) -- I only came across test files and META-INF/service definitions (both of which are somewhat expected). For the containing maven module, just add a pluginConfiguration entry in the pom.xml adding exclusions for the files. After this (or maybe after the first release -- so we have someone's eyes on it other than just mine), we can check off the other copyright box.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---