You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/07 13:04:11 UTC

[GitHub] MoritzMaxeiner commented on a change in pull request #13339: CMake: Enable installation of cpp-package headers

MoritzMaxeiner commented on a change in pull request #13339: CMake: Enable installation of cpp-package headers
URL: https://github.com/apache/incubator-mxnet/pull/13339#discussion_r239800236
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -730,6 +730,7 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
 )
 
 install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(DIRECTORY 3rdparty/tvm/nnvm/include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 
 Review comment:
   That's a bit out of scope for what I intended with the PR, but sure.
   You can find CMake's documentation [here](https://cmake.org/cmake/help/git-stage/command/install.html).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services