[GitHub] [incubator-doris] imay commented on a change in pull request #3345: [FIX] fix doris string functions not support multibyte string

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3345: [FIX] fix doris string functions not support multibyte string
URL: https://github.com/apache/incubator-doris/pull/3345#discussion_r410144966
 
 

 ##########
 File path: be/src/exprs/string_functions.cpp
 ##########
 @@ -223,6 +259,36 @@ IntVal StringFunctions::length(FunctionContext* context, const StringVal& str) {
     return IntVal(str.len);
 }
 
+// Implementation of CHAR_LENGTH
+//   int char_length(string input)
+// Returns the length of charactors of input. If input == NULL, returns
+// NULL per MySQL
+IntVal StringFunctions::char_length(FunctionContext* context, const StringVal& str) {
 
 Review comment:
   Is this only valid for UTF8 encode?
   If it is, better to rename `utf8_length`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org