[GitHub] [geode] nabarunnag commented on a change in pull request #6122: GEODE-9019: Serialization improvements in geode-redis (#6115)

[GitBox <gi...@apache.org>]

nabarunnag commented on a change in pull request #6122:
URL: https://github.com/apache/geode/pull/6122#discussion_r592772724



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -59,17 +62,31 @@ public RedisHash() {
     // for serialization
   }
 
+
   /**
    * Since GII (getInitialImage) can come in and call toData while other threads are modifying this
    * object, the striped executor will not protect toData. So any methods that modify "hash" needs
    * to be thread safe with toData.
    */
   @Override
-  public synchronized void toData(DataOutput out) throws IOException {
-    super.toData(out);
+  public void toData(DataOutput out, SerializationContext context) throws IOException {

Review comment:
       merge conflict! apologies




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org