You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/16 19:16:44 UTC
Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon and Vinod Kone.
Bugs: MESOS-1445
https://issues.apache.org/jira/browse/MESOS-1445
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/rate_limiting_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/22639/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/
-----------------------------------------------------------
(Updated June 19, 2014, 11:21 a.m.)
Review request for mesos, Dominic Hamon and Vinod Kone.
Changes
-------
Rebased. NNFR.
Bugs: MESOS-1445
https://issues.apache.org/jira/browse/MESOS-1445
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9
Diff: https://reviews.apache.org/r/22639/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/#review45886
-----------------------------------------------------------
Bad patch!
Reviews applied: [22639]
Failed command: git apply --index 22639.patch
Error:
error: src/tests/rate_limiting_tests.cpp: does not exist in index
- Mesos ReviewBot
On June 16, 2014, 5:16 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22639/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:16 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1445
> https://issues.apache.org/jira/browse/MESOS-1445
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22639/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/#review45781
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 16, 2014, 5:16 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22639/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:16 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1445
> https://issues.apache.org/jira/browse/MESOS-1445
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22639/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Vinod Kone <vi...@gmail.com>.
> On June 16, 2014, 5:19 p.m., Dominic Hamon wrote:
> > src/tests/rate_limiting_tests.cpp, line 56
> > <https://reviews.apache.org/r/22639/diff/1/?file=610723#file610723line56>
> >
> > why is this a macro? a method in the test fixture would work well.
>
> Jiang Yan Xu wrote:
> Theses checks AWAIT_READY, EXPECT_SOME_EQ, ASSERT_SOME are supposed to be put in a TEST method.
>
> Dominic Hamon wrote:
> they should work equally well in a test fixture method called from the test. This is far better than introducing a macro.
the advantage of having a macro here is that you get nice line numbers when one of the expectations in the macro fail.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/#review45775
-----------------------------------------------------------
On June 16, 2014, 5:16 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22639/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:16 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1445
> https://issues.apache.org/jira/browse/MESOS-1445
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22639/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On June 16, 2014, 10:19 a.m., Dominic Hamon wrote:
> > src/tests/rate_limiting_tests.cpp, line 56
> > <https://reviews.apache.org/r/22639/diff/1/?file=610723#file610723line56>
> >
> > why is this a macro? a method in the test fixture would work well.
Theses checks AWAIT_READY, EXPECT_SOME_EQ, ASSERT_SOME are supposed to be put in a TEST method.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/#review45775
-----------------------------------------------------------
On June 16, 2014, 10:16 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22639/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 10:16 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1445
> https://issues.apache.org/jira/browse/MESOS-1445
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22639/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On June 16, 2014, 10:19 a.m., Dominic Hamon wrote:
> > src/tests/rate_limiting_tests.cpp, line 56
> > <https://reviews.apache.org/r/22639/diff/1/?file=610723#file610723line56>
> >
> > why is this a macro? a method in the test fixture would work well.
>
> Jiang Yan Xu wrote:
> Theses checks AWAIT_READY, EXPECT_SOME_EQ, ASSERT_SOME are supposed to be put in a TEST method.
they should work equally well in a test fixture method called from the test. This is far better than introducing a macro.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/#review45775
-----------------------------------------------------------
On June 16, 2014, 10:16 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22639/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 10:16 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1445
> https://issues.apache.org/jira/browse/MESOS-1445
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22639/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22639: Refactored the querying and parsing of metrics
snapshot into a MACRO.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22639/#review45775
-----------------------------------------------------------
src/tests/rate_limiting_tests.cpp
<https://reviews.apache.org/r/22639/#comment80752>
why is this a macro? a method in the test fixture would work well.
- Dominic Hamon
On June 16, 2014, 10:16 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22639/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 10:16 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1445
> https://issues.apache.org/jira/browse/MESOS-1445
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/rate_limiting_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22639/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>