You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2012/10/09 21:58:03 UTC
[jira] [Created] (GIRAPH-361) Hive output partition parsing is
broken
Nitay Joffe created GIRAPH-361:
----------------------------------
Summary: Hive output partition parsing is broken
Key: GIRAPH-361
URL: https://issues.apache.org/jira/browse/GIRAPH-361
Project: Giraph
Issue Type: Bug
Reporter: Nitay Joffe
Assignee: Nitay Joffe
While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472891#comment-13472891 ]
Avery Ching commented on GIRAPH-361:
------------------------------------
+1, might as well commit now since only Nitay is using the Hive output stuff and this is in contrib.
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361-2.patch, GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-361:
-------------------------------
Attachment: GIRAPH-361-2.patch
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361-2.patch, GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-361:
-------------------------------
Attachment: GIRAPH-361.patch
Here's fix. I replaced the hand-written parsing logic with using Guava's Splitter. With this things are much more consistent and the parsing seems more correct.
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472889#comment-13472889 ]
Alessandro Presta commented on GIRAPH-361:
------------------------------------------
Looks good, +1.
I'll commit this tomorrow if no one objects.
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361-2.patch, GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated GIRAPH-361:
-------------------------------
Attachment: GIRAPH-361-3.patch
Yep, try this one.
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361-2.patch, GIRAPH-361-3.patch, GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472903#comment-13472903 ]
Alessandro Presta commented on GIRAPH-361:
------------------------------------------
Rat complains that HiveUtils.java and TestHiveUtils.java are missing the Apache License header. Nitay, can you please add it?
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361-2.patch, GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-361) Hive output partition parsing is
broken
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472931#comment-13472931 ]
Hudson commented on GIRAPH-361:
-------------------------------
Integrated in Giraph-trunk-Commit #232 (See [https://builds.apache.org/job/Giraph-trunk-Commit/232/])
Adding missing files from GIRAPH-361 (Revision 1396443)
GIRAPH-361: Hive output partition parsing is broken (nitay via apresta) (Revision 1396441)
Result = SUCCESS
apresta : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1396443
Files :
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HiveUtils.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java
apresta : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1396441
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph-formats-contrib/pom.xml
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HiveGiraphRunner.java
> Hive output partition parsing is broken
> ----------------------------------------
>
> Key: GIRAPH-361
> URL: https://issues.apache.org/jira/browse/GIRAPH-361
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-361-2.patch, GIRAPH-361-3.patch, GIRAPH-361.patch
>
>
> While running some jobs I've been seeing that the outputPartition option (-O in HiveGiraphRunner) is not parsing strings correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira