You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/07 10:45:23 UTC
[GitHub] [flink] dawidwys opened a new pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
dawidwys opened a new pull request #16095:
URL: https://github.com/apache/flink/pull/16095
## What is the purpose of the change
We revert the toggling between IDLE and ACTIVE status if a record is emitted in an IDLE state. If records are emitted in an IDLE state the toggling incur a lot of performance penalty.
## Verifying this change
All existing tests pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-855820927
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4 (Mon Jun 07 10:47:36 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-855820927
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6f885bcfe603f2ac289a0387cfc6c63af8aeda21 (Thu Sep 23 17:25:51 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-859501878
Aren't we still missing a test coverage for broadcasting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #16095:
URL: https://github.com/apache/flink/pull/16095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-855832242
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18741",
"triggerID" : "8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18741)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-855832242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-859402904
There is one additional comprehensive test that I forgot to revert. I removed it because we removed the behaviour for swallowing watermarks in IDLE channels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-855832242
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #16095:
URL: https://github.com/apache/flink/pull/16095#discussion_r649308476
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
##########
@@ -110,12 +108,14 @@ public void collect(StreamRecord<OUT> record) {
@Override
public void emitWatermark(Watermark mark) {
- // watermark could've been generated somewhere in the pipeline even though an IDLE status
- // was emitted. It might've originated from a periodic watermark generator or just a wrong
- // behaving operator
- try (AutoCloseable ignored = announcedStatus.ensureActive(this::writeStreamStatus)) {
- watermarkGauge.setCurrentWatermark(mark.getTimestamp());
- serializationDelegate.setInstance(mark);
+ if (announcedStatus.isIdle()) {
+ return;
+ }
Review comment:
This is as it it in 1.13 - emitting watermarks do not switch the status to active. But that's something that we might want to change in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #16095:
URL: https://github.com/apache/flink/pull/16095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16095:
URL: https://github.com/apache/flink/pull/16095#issuecomment-855832242
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18741",
"triggerID" : "8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8eacc9245e2339dea2ce4ec1a4b129d92cb61bb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18741)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16095: [FLINK-22881][runtime] Revert toggling IDLE/ACTIVE on records in IDLE state
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16095:
URL: https://github.com/apache/flink/pull/16095#discussion_r649763606
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
##########
@@ -110,12 +108,14 @@ public void collect(StreamRecord<OUT> record) {
@Override
public void emitWatermark(Watermark mark) {
- // watermark could've been generated somewhere in the pipeline even though an IDLE status
- // was emitted. It might've originated from a periodic watermark generator or just a wrong
- // behaving operator
- try (AutoCloseable ignored = announcedStatus.ensureActive(this::writeStreamStatus)) {
- watermarkGauge.setCurrentWatermark(mark.getTimestamp());
- serializationDelegate.setInstance(mark);
+ if (announcedStatus.isIdle()) {
+ return;
+ }
Review comment:
Yes, in 1.13 we ignore/swallow watermarks emitted in the `IDLE`state. There we check the status via `StreamStatusProvider` though.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
##########
@@ -110,12 +108,14 @@ public void collect(StreamRecord<OUT> record) {
@Override
public void emitWatermark(Watermark mark) {
- // watermark could've been generated somewhere in the pipeline even though an IDLE status
- // was emitted. It might've originated from a periodic watermark generator or just a wrong
- // behaving operator
- try (AutoCloseable ignored = announcedStatus.ensureActive(this::writeStreamStatus)) {
- watermarkGauge.setCurrentWatermark(mark.getTimestamp());
- serializationDelegate.setInstance(mark);
+ if (announcedStatus.isIdle()) {
+ return;
+ }
Review comment:
The comment about tests reminded me that I dropped a test for it along with the behaviour in outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org