You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "LouisGariepy (via GitHub)" <gi...@apache.org> on 2023/06/12 01:47:35 UTC

[GitHub] [arrow-datafusion] LouisGariepy opened a new pull request, #6640: Clippy module inception

LouisGariepy opened a new pull request, #6640:
URL: https://github.com/apache/arrow-datafusion/pull/6640

   # Which issue does this PR close?
   
   Closes #6496.
   
   # Rationale for this change
   
   Explained more in-depth in the linked issue, but basically this PR removes instances of module inception, which happens when you have paths like `foo::foo`.
   
   # What changes are included in this PR?
   
   Moved the contents of `catalog::catalog` into its parent (`catalog`), and renamed `datasource::datasource` to `datasource::provider`.
   
   # Are these changes tested?
   
   No tests needed
   
   # Are there any user-facing changes?
   
   Yes, the two modules (`catalog::catalog` and `datasource::datasource`) are public AFAICT.
   
   # Note
   
   There are alternative ways to solve this that have been discussed in #6496. I'd like to get some feedback on these Vs what I have implemented here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6640: Fix Clippy module inception (unwrap `datasource::datasource` and `catalog::catalog`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6640:
URL: https://github.com/apache/arrow-datafusion/pull/6640#issuecomment-1588295699

   Thanks again @LouisGariepy 🦾 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6640: Fix Clippy module inception (unwrap `datasource::datasource` and `catalog::catalog`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6640:
URL: https://github.com/apache/arrow-datafusion/pull/6640


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6640: Fix Clippy module inception (unwrap `datasource::datasource` and `catalog::catalog`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6640:
URL: https://github.com/apache/arrow-datafusion/pull/6640#issuecomment-1587850383

   I merged up from master to resolve a conflict with this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org