You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2010/10/17 17:39:23 UTC
[jira] Created: (THRIFT-960) add TestServer, TestNonblockingServer
and TestClient again
add TestServer, TestNonblockingServer and TestClient again
----------------------------------------------------------
Key: THRIFT-960
URL: https://issues.apache.org/jira/browse/THRIFT-960
Project: Thrift
Issue Type: Improvement
Components: Java - Library
Affects Versions: 0.5
Reporter: Roger Meier
Assignee: Roger Meier
Fix For: 0.6
* add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
* TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
* create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
* ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-960) add TestServer, TestNonblockingServer
and TestClient again
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-960:
-------------------------------
Component/s: Test Suite
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-960) add TestServer,
TestNonblockingServer and TestClient again
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923166#action_12923166 ]
Bryan Duxbury commented on THRIFT-960:
--------------------------------------
Why all the changes to the classpath stuff in build.xml? Looks a little confusing to me.
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-960) add TestServer, TestNonblockingServer
and TestClient again
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-960:
-------------------------------
Attachment: THRIFT-960_Java_add_TestServer_and_Client_again.patch
please review the patch, i like to commit this soon.
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-960) add TestServer,
TestNonblockingServer and TestClient again
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924266#action_12924266 ]
Roger Meier commented on THRIFT-960:
------------------------------------
I'm very sorry about these extra commits and late changes... I forgot to adopt to AbstractServerArgs .introduced with THRIFT-745 ...
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch, THRIFT-960_Java_add_TestServer_and_Client_again.v2.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-960) add TestServer, TestNonblockingServer
and TestClient again
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier closed THRIFT-960.
------------------------------
Resolution: Fixed
classpath issue was fixed and no other concerns occurred, so I committed that.
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch, THRIFT-960_Java_add_TestServer_and_Client_again.v2.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-960) add TestServer, TestNonblockingServer
and TestClient again
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-960:
-------------------------------
Attachment: THRIFT-960_Java_add_TestServer_and_Client_again.v2.patch
You are right Bryan, the classpath modifications are not required.
I had a closer look,
add the depends to the testserver target is enough because it depends on resolve which sets the ivy.test.classpath => new patch without classpath modifications.
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch, THRIFT-960_Java_add_TestServer_and_Client_again.v2.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-960) add TestServer,
TestNonblockingServer and TestClient again
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924699#action_12924699 ]
Roger Meier commented on THRIFT-960:
------------------------------------
one more ... removed TestServer, TestNonblockingServer and TestClient from Unittest
> add TestServer, TestNonblockingServer and TestClient again
> ----------------------------------------------------------
>
> Key: THRIFT-960
> URL: https://issues.apache.org/jira/browse/THRIFT-960
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library, Test Suite
> Affects Versions: 0.5
> Reporter: Roger Meier
> Assignee: Roger Meier
> Fix For: 0.6
>
> Attachments: THRIFT-960_Java_add_TestServer_and_Client_again.patch, THRIFT-960_Java_add_TestServer_and_Client_again.v2.patch
>
>
> * add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
> * TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
> * create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
> * ant targets testclient, testserver and testnonblockingserver will be able to run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.