You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/04/13 09:59:24 UTC

[GitHub] incubator-carbondata pull request #790: [CARBONDATA-919]result_size in query...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/790#discussion_r111353177
  
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -147,7 +148,11 @@ public VectorizedCarbonRecordReader(QueryModel queryModel) {
       }
     
       @Override public Object getCurrentValue() throws IOException, InterruptedException {
    -    if (returnColumnarBatch) return columnarBatch;
    +    if (returnColumnarBatch) {
    +      rowCount += columnarBatch.numValidRows();
    +      return columnarBatch;
    +    }
    +    rowCount += 1;
    --- End diff --
    
    why incrementing with 1 again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---