[jira] [Commented] (DRILL-8324) remove dependency on java-sizeof jar

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613210#comment-17613210 ] 

ASF GitHub Bot commented on DRILL-8324:
---------------------------------------

pjfanning commented on PR #2665:
URL: https://github.com/apache/drill/pull/2665#issuecomment-1268917234

   @cgivre My PR uses the latest Spark code for the SizeEstimator as opposed to very old copy of the Spark code that was copied and not maintained in java-sizeof lib. The new code gives slightly higher estimates for object instance sizes. Would this be an issue? 
   
   Also, with tests - Spark and the java-sizeof lib use some Scala based tests - and they are not that easily replicated in Java. The question is whether the tests that I've added in this PR or if I need more.




> remove dependency on java-sizeof jar
> ------------------------------------
>
>                 Key: DRILL-8324
>                 URL: https://issues.apache.org/jira/browse/DRILL-8324
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: PJ Fanning
>            Priority: Major
>
> [https://github.com/phatak-dev/java-sizeof] is not maintained and ties us to a very old version of Scala.
> It looks like it should be easy to rewrite the code in Java and have it in Drill itself.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)