You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/26 00:05:27 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#9202: [dashboard perf logging] add dashboard url anchor component id
graceguo-supercat opened a new pull request #9202: [dashboard perf logging] add dashboard url anchor component id
URL: https://github.com/apache/incubator-superset/pull/9202
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Dashboard supports nested tabs and charts. But user can add anchor in the request url, and dashboard will be landed with the component in the anchor. For example:
https://superset.d.musta.ch/superset/dashboard/homes/#TAB-DZy3k25d_ will open a specific tab.
https://superset.d.musta.ch/superset/dashboard/homes/#CHART-59WSceLod1 will open a specific chart.
This PR is to add the anchor component into dashboard perf log, so that we can see which tab/charts are more popular. This will help dashboard warm-up tasks.
### TEST PLAN
CI and manual test.
### REVIEWERS
@serenajiang @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #9202:
[dashboard perf logging] add dashboard url anchor component id
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #9202: [dashboard perf logging] add dashboard url anchor component id
URL: https://github.com/apache/incubator-superset/pull/9202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9202:
[dashboard perf logging] add dashboard url anchor component id
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9202: [dashboard perf logging] add dashboard url anchor component id
URL: https://github.com/apache/incubator-superset/pull/9202#issuecomment-591232986
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=h1) Report
> Merging [#9202](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1992069af10a84c0311be57f9be221711ca84be0?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9202 +/- ##
==========================================
+ Coverage 58.91% 58.91% +<.01%
==========================================
Files 372 372
Lines 11992 11996 +4
Branches 2936 2937 +1
==========================================
+ Hits 7065 7068 +3
- Misses 4749 4750 +1
Partials 178 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9202/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `84.37% <80%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=footer). Last update [1992069...1537fa5](https://codecov.io/gh/apache/incubator-superset/pull/9202?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org