You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2010/02/04 10:54:28 UTC

[jira] Created: (AVRO-400) Adding warning for unused parameters

Adding warning for unused parameters
------------------------------------

                 Key: AVRO-400
                 URL: https://issues.apache.org/jira/browse/AVRO-400
             Project: Avro
          Issue Type: Improvement
          Components: c
            Reporter: Eli Collins
            Priority: Minor


Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-400) Adding warning for unused parameters

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated AVRO-400:
-----------------------------

    Attachment: avro-400-2.patch

Updated patch attached. Adds warnings for unused parameters to the relevant makefiles but doesn't remove the unused parameters that the last patch did (those will be used in the future). Also corrects the type of the size field in avro_fixed_schema_t and a printf format string in lang/c/examples/quickstop.c



> Adding warning for unused parameters
> ------------------------------------
>
>                 Key: AVRO-400
>                 URL: https://issues.apache.org/jira/browse/AVRO-400
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Eli Collins
>            Assignee: Matt Massie
>            Priority: Minor
>         Attachments: avro-400-1.patch, avro-400-2.patch
>
>
> Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-400) Adding warning for unused parameters

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Massie updated AVRO-400:
-----------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed to trunk.   Thanks, Eli.

> Adding warning for unused parameters
> ------------------------------------
>
>                 Key: AVRO-400
>                 URL: https://issues.apache.org/jira/browse/AVRO-400
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: avro-400-1.patch, avro-400-2.patch
>
>
> Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-400) Adding warning for unused parameters

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated AVRO-400:
-----------------------------

    Status: Patch Available  (was: Open)

> Adding warning for unused parameters
> ------------------------------------
>
>                 Key: AVRO-400
>                 URL: https://issues.apache.org/jira/browse/AVRO-400
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Eli Collins
>            Priority: Minor
>         Attachments: avro-400-1.patch
>
>
> Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AVRO-400) Adding warning for unused parameters

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Massie reassigned AVRO-400:
--------------------------------

    Assignee: Matt Massie

> Adding warning for unused parameters
> ------------------------------------
>
>                 Key: AVRO-400
>                 URL: https://issues.apache.org/jira/browse/AVRO-400
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Eli Collins
>            Assignee: Matt Massie
>            Priority: Minor
>         Attachments: avro-400-1.patch
>
>
> Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-400) Adding warning for unused parameters

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated AVRO-400:
-----------------------------

    Attachment: avro-400-1.patch

> Adding warning for unused parameters
> ------------------------------------
>
>                 Key: AVRO-400
>                 URL: https://issues.apache.org/jira/browse/AVRO-400
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Eli Collins
>            Priority: Minor
>         Attachments: avro-400-1.patch
>
>
> Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AVRO-400) Adding warning for unused parameters

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins reassigned AVRO-400:
--------------------------------

    Assignee: Eli Collins  (was: Matt Massie)

> Adding warning for unused parameters
> ------------------------------------
>
>                 Key: AVRO-400
>                 URL: https://issues.apache.org/jira/browse/AVRO-400
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: avro-400-1.patch, avro-400-2.patch
>
>
> Adds -Wextra -Wunused-parameter to the C makefiles and removes a bunch of unused parameters. Matt, lemme know if you had left these parameters in for future use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.