[jira] [Commented] (ARROW-14889) [C++] GCFS tests hang if testbench not installed

["Will Jones (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561563#comment-17561563 ] 

Will Jones commented on ARROW-14889:
------------------------------------

Looked into this a little bit. It seems that we start the process, and consider it successful if we check that {{server_process_.running()}} is immediately true. In the case of ImportError, the timing can work out where it's still running at the time of the first check, but isn't later. So API calls then hang.

The ideal solution is to alter the initialization to wait for an affirmative message that the testbench process is running. Possibly a startup message from testbench?

> [C++] GCFS tests hang if testbench not installed
> ------------------------------------------------
>
>                 Key: ARROW-14889
>                 URL: https://issues.apache.org/jira/browse/ARROW-14889
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Antoine Pitrou
>            Priority: Major
>
> They should probably error out instead of hanging.
> {code}
> Running main() from /home/antoine/arrow/dev/cpp/build-preset/googletest_ep-prefix/src/googletest_ep/googletest/src/gtest_main.cc
> [==========] Running 22 tests from 2 test suites.
> [----------] Global test environment set-up.
> [----------] 13 tests from GcsFileSystem
> [ RUN      ] GcsFileSystem.OptionsCompare
> [       OK ] GcsFileSystem.OptionsCompare (0 ms)
> [ RUN      ] GcsFileSystem.ToArrowStatusOK
> [       OK ] GcsFileSystem.ToArrowStatusOK (0 ms)
> [ RUN      ] GcsFileSystem.ToArrowStatus
> [       OK ] GcsFileSystem.ToArrowStatus (0 ms)
> [ RUN      ] GcsFileSystem.FileSystemCompare
> [       OK ] GcsFileSystem.FileSystemCompare (2 ms)
> [ RUN      ] GcsFileSystem.ToEncryptionKey
> [       OK ] GcsFileSystem.ToEncryptionKey (0 ms)
> [ RUN      ] GcsFileSystem.ToEncryptionKeyEmpty
> [       OK ] GcsFileSystem.ToEncryptionKeyEmpty (0 ms)
> [ RUN      ] GcsFileSystem.ToKmsKeyName
> [       OK ] GcsFileSystem.ToKmsKeyName (0 ms)
> [ RUN      ] GcsFileSystem.ToKmsKeyNameEmpty
> [       OK ] GcsFileSystem.ToKmsKeyNameEmpty (0 ms)
> [ RUN      ] GcsFileSystem.ToPredefinedAcl
> [       OK ] GcsFileSystem.ToPredefinedAcl (0 ms)
> [ RUN      ] GcsFileSystem.ToPredefinedAclEmpty
> [       OK ] GcsFileSystem.ToPredefinedAclEmpty (0 ms)
> [ RUN      ] GcsFileSystem.ToObjectMetadata
> [       OK ] GcsFileSystem.ToObjectMetadata (0 ms)
> [ RUN      ] GcsFileSystem.ToObjectMetadataEmpty
> [       OK ] GcsFileSystem.ToObjectMetadataEmpty (0 ms)
> [ RUN      ] GcsFileSystem.ToObjectMetadataInvalidCustomTime
> [       OK ] GcsFileSystem.ToObjectMetadataInvalidCustomTime (0 ms)
> [----------] 13 tests from GcsFileSystem (3 ms total)
> [----------] 9 tests from GcsIntegrationTest
> [ RUN      ] GcsIntegrationTest.GetFileInfoBucket
> /home/antoine/miniconda3/envs/pyarrow/bin/python3: No module named testbench
> ^C
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)