You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (Created) (JIRA)" <ji...@apache.org> on 2011/12/13 21:04:30 UTC

[jira] [Created] (DERBY-5535) Remove unused methods from client's CrossConverters class.

Remove unused methods from client's CrossConverters class.
----------------------------------------------------------

                 Key: DERBY-5535
                 URL: https://issues.apache.org/jira/browse/DERBY-5535
             Project: Derby
          Issue Type: Improvement
          Components: Network Client
            Reporter: Dag H. Wanvik
            Priority: Trivial


The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):

getBooleanFromBigDecimal
getByteFromBigDecimal
getShortFromBigDecimal
getIntFromBigDecimal
getLongFromBigDecimal
getFloatFromBigDecimal
getDoubleFromBigDecimal



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (DERBY-5535) Remove unused methods from client's CrossConverters class.

Posted by "Dag H. Wanvik (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik reassigned DERBY-5535:
------------------------------------

    Assignee: Dag H. Wanvik
    
> Remove unused methods from client's CrossConverters class.
> ----------------------------------------------------------
>
>                 Key: DERBY-5535
>                 URL: https://issues.apache.org/jira/browse/DERBY-5535
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>
> The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):
> getBooleanFromBigDecimal
> getByteFromBigDecimal
> getShortFromBigDecimal
> getIntFromBigDecimal
> getLongFromBigDecimal
> getFloatFromBigDecimal
> getDoubleFromBigDecimal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DERBY-5535) Remove unused methods from client's CrossConverters class.

Posted by "Dag H. Wanvik (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik resolved DERBY-5535.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 10.9.0.0
    
> Remove unused methods from client's CrossConverters class.
> ----------------------------------------------------------
>
>                 Key: DERBY-5535
>                 URL: https://issues.apache.org/jira/browse/DERBY-5535
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5535.diff
>
>
> The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):
> getBooleanFromBigDecimal
> getByteFromBigDecimal
> getShortFromBigDecimal
> getIntFromBigDecimal
> getLongFromBigDecimal
> getFloatFromBigDecimal
> getDoubleFromBigDecimal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (DERBY-5535) Remove unused methods from client's CrossConverters class.

Posted by "Dag H. Wanvik (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-5535:
---------------------------------

    Attachment: derby-5535.diff

Attaching a patch to remove the unused methods.
                
> Remove unused methods from client's CrossConverters class.
> ----------------------------------------------------------
>
>                 Key: DERBY-5535
>                 URL: https://issues.apache.org/jira/browse/DERBY-5535
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>         Attachments: derby-5535.diff
>
>
> The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):
> getBooleanFromBigDecimal
> getByteFromBigDecimal
> getShortFromBigDecimal
> getIntFromBigDecimal
> getLongFromBigDecimal
> getFloatFromBigDecimal
> getDoubleFromBigDecimal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (DERBY-5535) Remove unused methods from client's CrossConverters class.

Posted by "Dag H. Wanvik (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169624#comment-13169624 ] 

Dag H. Wanvik commented on DERBY-5535:
--------------------------------------

Regressions ran ok, committed patch at svn 1214423, closing.

                
> Remove unused methods from client's CrossConverters class.
> ----------------------------------------------------------
>
>                 Key: DERBY-5535
>                 URL: https://issues.apache.org/jira/browse/DERBY-5535
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5535.diff
>
>
> The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):
> getBooleanFromBigDecimal
> getByteFromBigDecimal
> getShortFromBigDecimal
> getIntFromBigDecimal
> getLongFromBigDecimal
> getFloatFromBigDecimal
> getDoubleFromBigDecimal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (DERBY-5535) Remove unused methods from client's CrossConverters class.

Posted by "Dag H. Wanvik (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik closed DERBY-5535.
--------------------------------

    
> Remove unused methods from client's CrossConverters class.
> ----------------------------------------------------------
>
>                 Key: DERBY-5535
>                 URL: https://issues.apache.org/jira/browse/DERBY-5535
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5535.diff
>
>
> The following methods in CrossConverters are not used (client code uses an optimized path, cf. e.g. getInt in am.Cursor.java which has this comment "For performance we don't materialize the BigDecimal, but convert directly from decimal bytes to a long"):
> getBooleanFromBigDecimal
> getByteFromBigDecimal
> getShortFromBigDecimal
> getIntFromBigDecimal
> getLongFromBigDecimal
> getFloatFromBigDecimal
> getDoubleFromBigDecimal

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira