You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Christian Geisert (JIRA)" <ji...@apache.org> on 2008/03/07 18:05:46 UTC
[jira] Created: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Decimal formatting messed up in Trial Balance with German locale
----------------------------------------------------------------
Key: OFBIZ-1696
URL: https://issues.apache.org/jira/browse/OFBIZ-1696
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Environment: svn trunk with clean-all run-install
Reporter: Christian Geisert
This is the Trial Balance after one sales order (4 x GZ-1000)
Trial Balance
Gl Account Id Debit Credit
[120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
[140000] [140000] INVENTORY 300,00 $
[400000] [400000] SALES 4.797,00 $
[410000] [410000] DISCOUNTS ON SALES 48,00 $
[500000] [500000] COST OF GOODS SOLD 300,00 $
Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
(I'll attach this also as an image)
ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
<set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Christian Geisert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580440#action_12580440 ]
Christian Geisert commented on OFBIZ-1696:
------------------------------------------
Adrian,
as in this case the values are coming from the database (set from an entity-one field within a row-actions) your patch doesn't fix the problem
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1696:
-------------------------------
Attachment: (was: locale_timezone_refactor.patch)
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Christian Geisert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598150#action_12598150 ]
Christian Geisert commented on OFBIZ-1696:
------------------------------------------
Looks good after a first quick test.
I'll remove "user.language=en" from startofbiz.sh after some more testing ;-)
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff, Still problems with german trial balance.jpg
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1696:
-------------------------------
Attachment: (was: locale_timezone_refactor.patch)
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576293#action_12576293 ]
Jacques Le Roux commented on OFBIZ-1696:
----------------------------------------
Hi Christian, Jacopo,
Not sure if adding "-Duser.language=en" is the better way to go, sounds like a camouflage to me.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577475#action_12577475 ]
Adrian Crum commented on OFBIZ-1696:
------------------------------------
My two cents:
I agree that there needs to be more work done to clean up how locales are handled. I had considered setting up a configurable default locale - similar to the configurable default time zone that exists now. I would also like to see all locale utility or "worker" code moved to its own utility class, but that's getting a bit off topic.
Looking at Christian's patch, it seems to me it would be better to get the user's locale from the context Map, and if it doesn't exist in there, then go get the default locale.
A general best practice for working with Locale arguments is to supply something rather than passing a null (which is something Christian's patch fixes). The reason is, if you're not specific about your intentions, then there is no way to know what the framework code is going to do with that null argument.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1696:
-------------------------------
Attachment: locale_timezone_refactor.patch
Last try. Sorry.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1696:
-------------------------------
Attachment: locale_timezone_refactor.patch
locale_timezone_refactor.patch is a locale and time zone refactoring effort I'm working on. Give it a try and see if it solves this problem. It has solved a few others that I'm aware of.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576280#action_12576280 ]
Jacopo Cappellato commented on OFBIZ-1696:
------------------------------------------
Christian,
thanks for your tests and feedback.
I am the first to admit that the data preparation code can be greatly improved.
However, my vote would be to re-add the -Duser.language=en parameter to the starting scripts... now I remember that the parameter was not there just for the uilabels selections, but also to fix some numeric formatting issues...
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1696:
--------------------------------------
Assignee: Jacques Le Roux
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584194#action_12584194 ]
Jacques Le Roux commented on OFBIZ-1696:
----------------------------------------
As we have no better solutions for now, I put back -Duser.language=en in trunk revision: 643459
I keep this issue open, hopefully one day we will solve it...
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Christian Geisert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Geisert updated OFBIZ-1696:
-------------------------------------
Attachment: ofbiz_trialbalance_german.png
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum closed OFBIZ-1696.
------------------------------
Resolution: Fixed
Fixed, rev 658045.
Jacques - thank you for your assistance.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff, Still problems with german trial balance.jpg
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-1696:
-----------------------------------
Attachment: Still problems with german trial balance.jpg
Adrian I tested, sounds better but not correct
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff, Still problems with german trial balance.jpg
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Christian Geisert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576934#action_12576934 ]
Christian Geisert commented on OFBIZ-1696:
------------------------------------------
Jacopo,
yes, I think it's ok as a *temporary fix* but eventually it should be fixed properly
(looking currently at ModelFormAction.java ;-)
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Christian Geisert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Geisert updated OFBIZ-1696:
-------------------------------------
Attachment: patch_ofbiz_convert_locale.diff
A patch which seems fixes this issue.
But this needs more testing/analyses for side-effects and should be reviewed by someone with more framework knowledge
Do not commit.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1696:
-------------------------------
Attachment: locale_timezone_refactor.patch
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Assignee: Jacques Le Roux
> Attachments: locale_timezone_refactor.patch, ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1696) Decimal formatting messed up in
Trial Balance with German locale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576296#action_12576296 ]
Jacques Le Roux commented on OFBIZ-1696:
----------------------------------------
BTW, I made an answer to Si about such a topic which may turn usefull here :
Hi Si,
It has been solved in r429249 by David without using this parameter.
It was effectively related to old Jira OFBIZ-136 you reported and where you suggested to use this parameter + "-Duser.region=US.
Note that this last parameter was not used in startofbiz.*. This because this parameter was solely introduced in r452792 by
Jacopo, following a suggestion I made in old Jira OFBIZ-877.
Fisheye can't be used here because it was pre-Apache changes
http://fisheye6.cenqua.com/browse/ofbiz/trunk/startofbiz.bat
Jacques
> Jacques,
>
> This was put there because there were numerical parsing problems in minilang, which I don't think have been solved yet.
>
Please see http://www.nabble.com/Re%3A-svn-commit%3A-r631937---in--ofbiz-trunk%3A-startofbiz.bat-startofbiz.sh-tt15742840.html
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_trialbalance_german.png
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1696) Decimal formatting messed up in Trial
Balance with German locale
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1696:
-------------------------------
Attachment: ofbiz_1696.patch
ofbiz_1696.patch is a modification of Christian's patch to demonstrate how I think the object conversions should be handled.
If something like this was done, then it would have to be done everywhere ObjectType.simpleTypeConvert(...) is called, otherwise we will have inconsistent results.
> Decimal formatting messed up in Trial Balance with German locale
> ----------------------------------------------------------------
>
> Key: OFBIZ-1696
> URL: https://issues.apache.org/jira/browse/OFBIZ-1696
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: svn trunk with clean-all run-install
> Reporter: Christian Geisert
> Attachments: ofbiz_1696.patch, ofbiz_trialbalance_german.png, patch_ofbiz_convert_locale.diff
>
>
> This is the Trial Balance after one sales order (4 x GZ-1000)
> Trial Balance
> Gl Account Id Debit Credit
> [120000] [120000] ACCOUNTS RECEIVABLE 4.317,00 $
> [140000] [140000] INVENTORY 300,00 $
> [400000] [400000] SALES 4.797,00 $
> [410000] [410000] DISCOUNTS ON SALES 48,00 $
> [500000] [500000] COST OF GOODS SOLD 300,00 $
> Gesamtsumme 43.170.780.000.000.000.000,00 $ 7.797.000,00 $
> (I'll attach this also as an image)
> ACCOUNTS RECEIVABLE should be 43,17 $ instead of 4.317,00 $
> Strange, postedBalance is ok in GlAccountOrganization, it looks like the following line messes it up:
> <set field="absolutePostedBalance" value="${bsh:(postedBalance >= 0? postedBalance: (-1)*postedBalance)}" type="Double"/>
> If I start OFBiz with the English locale (-Duser.language=en) the Trial Balance looks correct.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.