You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/22 17:41:00 UTC
[jira] [Commented] (COMPRESS-413) Travis build redundantly repeats
compilation and tests redundantly
[ https://issues.apache.org/jira/browse/COMPRESS-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059730#comment-16059730 ]
ASF GitHub Bot commented on COMPRESS-413:
-----------------------------------------
GitHub user sesuncedu opened a pull request:
https://github.com/apache/commons-compress/pull/39
COMPRESS-413: Performance improvements for Travis builds
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco profile if one exists.
- clean
- apache-rat:check
- test
- jacoco:report
- coveralls:report
- This will fail the build if any of the above goals fail. The goals that are most likely to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail the build if the service is not available (e.g. for forks that do not have repository registered with coveralls).
- Note that the apache-rat: check could be added to the pom (executing by default in the validate phase)
- Also note that the jacoco:check goal can be added to the pom (executing by default in the verify phase).
- the script could then be changed to execute the verify goal.
- coveralls stuff could be run in an after_success script. That script could restrict coveralls notification to a single point in the jdk matrix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit ed024e9a6de41f72655674f0c7cdcce5700cf82d
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-19T20:15:16Z
add mvnw
(cherry picked from commit 91a08f4)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 8d543fd017f5c963f25541109fd48ceba1e0666c
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T16:13:45Z
COMPRESS-413
Alter pom.xml:
- Add Simon Spero as contributor.
- change javadoc configuration to use <docencoding> (lowercase e) instead of <docEncoding> (uppercase E).
- see https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#docencoding
- exclude .mvn/** from rat check (mvnw and mvnw.cmd are ok since they already have APL header).
- add plugin configuration for coveralls to pluginManagement. Set failOnServiceError to false to avoid breaking the build
if coveralls is not available
Signed-off-by: Simon Spero <se...@gmail.com>
commit 95974fc671661244c83fdead2231f8367a67d2ba
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T17:00:13Z
COMPRESS-413
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco profile if one exists.
- clean
- apache-rat:check
- test
- jacoco:report
- coveralls:report
- This will fail the build if any of the above goals fail. The goals that are most likely to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail the build if the service is not available (e.g. for forks that do not have repository registered with coveralls).
- Note that the apache-rat: check could be added to the pom (executing by default in the validate phase)
- Also note that the jacoco:check goal can be added to the pom (executing by default in the verify phase).
- the script could then be changed to execute the verify goal.
- coveralls stuff could run in a after_success script that checked and only ran for a selected jdk
Signed-off-by: Simon Spero <se...@gmail.com>
----
> Travis build redundantly repeats compilation and tests redundantly
> ------------------------------------------------------------------
>
> Key: COMPRESS-413
> URL: https://issues.apache.org/jira/browse/COMPRESS-413
> Project: Commons Compress
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.14
> Environment: Travis
> Reporter: Simon Spero
> Priority: Minor
> Labels: CI
> Fix For: 1.15
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Travis build setup is suboptimal.
> At the moment, code is compiled and installed by the default install phase.
> Then the default build phase is executed, which compiles and runs the tests.
> If the tests succeed, then the build is cleaned, recompiled, and retested; this time with
> coverage enabled.
> The .travis.yml file could be changed to skip the install phase, and to run tests with coverage during the build phase.
> The coveralls plugin can be configured in the pom to not fail the build if the service is unreachable, so forks that don't have jacoco enabled won't always have their builds fail.
> Also, the jdk switching in the trusty container seems to be not working properly at the moment, so installing a jdk7 doesn't work properly.
> These changes evolved as I was poking jenkins last night.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)