You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/09 01:46:06 UTC
[GitHub] [iotdb] tisonkun opened a new pull request, #7942: cleanup spotless workaround code and doc
tisonkun opened a new pull request, #7942:
URL: https://github.com/apache/iotdb/pull/7942
This is a follow-up of #6441.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] tisonkun commented on pull request #7942: cleanup spotless workaround code and doc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #7942:
URL: https://github.com/apache/iotdb/pull/7942#issuecomment-1308108176
@HTHou I think with #6441 the spotless version already supports doing this. This PR is to clean up workaround settings and incorrect docs.
I ran `mvn spotless:apply` locally with JDK17 and it doesn't complain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7942: cleanup spotless workaround code and doc
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7942:
URL: https://github.com/apache/iotdb/pull/7942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #7942: cleanup spotless workaround code and doc
Posted by GitBox <gi...@apache.org>.
HTHou commented on PR #7942:
URL: https://github.com/apache/iotdb/pull/7942#issuecomment-1308106015
So, we can run `mvn spotless:apply` with jdk 17 now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] tisonkun commented on pull request #7942: cleanup spotless workaround code and doc
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #7942:
URL: https://github.com/apache/iotdb/pull/7942#issuecomment-1308083635
cc @HTHou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org