You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/10/04 22:03:07 UTC
[GitHub] [samza] Sanil15 opened a new pull request #1180: Samza-2340
[WIP][DO_NOT_REVIEW]: Introduce ContainerManager for handling,
validation failures & starts for active & standby containers
Sanil15 opened a new pull request #1180: Samza-2340 [WIP][DO_NOT_REVIEW]: Introduce ContainerManager for handling, validation failures & starts for active & standby containers
URL: https://github.com/apache/samza/pull/1180
**Summary**
- Introduce a ContainerManager that can act a single entity maintaining state for validation, starts & failures of any requests relating to active & standby containers
- The ContainerProcessManager & ContainerAllocator should call the ContaineProcessManager for any state validation & for fetching the next set of actions for successful & failed start & stop of active & standby cotntainer
- ContainerManager should encapsulate the related state & logic behind StandBy & Active Container control actions
**What does this PR ADD?**
- Introducer a new class ContainerManager
- Removes StandByContainerManager from ContainerProcessManager & ContainerAllocator. Encapsulates StandByContainerManager inside ContainerManager
- Moves the logic to determine the next set of actions on container stop failures & container launch failures from ContainerProcessManager to ContainerManager
- Move the logic of validating allocated resources & expired requests from ContainerAllocator to ContainerManager
**Rational**
- Centralizing the logic and state maintenance for active & standby containers helps to add & test new features faster and improve code readability
**Note**: This PR does not add any new behaviors in the AppMaster ecosystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services