You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/27 01:40:31 UTC
[GitHub] [skywalking] VictorZeng opened a new pull request #7813: Add component definition for Jackson.
VictorZeng opened a new pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #7812 .
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#discussion_r716314081
##########
File path: changes/changes-8.8.0.md
##########
@@ -75,7 +75,7 @@ Release Notes.
low down metrics flush period added in 8.7.0.
* Fix `Slow SQL sampling` not accurate, due to TopN works conflict with cache read-then-clear mechanism.
* The persistent cache is only read when necessary.
-* Add component definition for `Alibaba Fastjson`.
+* Add component definition for `Alibaba Fastjson` and `Jackson`.
Review comment:
Java agent is going to use its own version from this month. There are no relationship, version relationship is described in https://skywalking.apache.org/docs/main/latest/en/setup/service-agent/agent-compatibility/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#discussion_r716311714
##########
File path: changes/changes-8.8.0.md
##########
@@ -75,7 +75,7 @@ Release Notes.
low down metrics flush period added in 8.7.0.
* Fix `Slow SQL sampling` not accurate, due to TopN works conflict with cache read-then-clear mechanism.
* The persistent cache is only read when necessary.
-* Add component definition for `Alibaba Fastjson`.
+* Add component definition for `Alibaba Fastjson` and `Jackson`.
Review comment:
This is main repository's release log, which has started. https://lists.apache.org/thread.html/rde5ccf89acdf60215b4409097273bf171b81fdda8d22370f4a33414a%40%3Cdev.skywalking.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] VictorZeng commented on a change in pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
VictorZeng commented on a change in pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#discussion_r716312633
##########
File path: changes/changes-8.8.0.md
##########
@@ -75,7 +75,7 @@ Release Notes.
low down metrics flush period added in 8.7.0.
* Fix `Slow SQL sampling` not accurate, due to TopN works conflict with cache read-then-clear mechanism.
* The persistent cache is only read when necessary.
-* Add component definition for `Alibaba Fastjson`.
+* Add component definition for `Alibaba Fastjson` and `Jackson`.
Review comment:
OK, will reset it , but the java-agent verison is 8.8.0-SNAPSHOT, is OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#issuecomment-927445851
Pending on https://github.com/apache/skywalking-java/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] VictorZeng commented on pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
VictorZeng commented on pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#issuecomment-927450145
Maybe the plugin should be in version 8.8.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#discussion_r716311448
##########
File path: changes/changes-8.8.0.md
##########
@@ -75,7 +75,7 @@ Release Notes.
low down metrics flush period added in 8.7.0.
* Fix `Slow SQL sampling` not accurate, due to TopN works conflict with cache read-then-clear mechanism.
* The persistent cache is only read when necessary.
-* Add component definition for `Alibaba Fastjson`.
+* Add component definition for `Alibaba Fastjson` and `Jackson`.
Review comment:
You should not move to here. The original version is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#discussion_r716312089
##########
File path: changes/changes-8.8.0.md
##########
@@ -75,7 +75,7 @@ Release Notes.
low down metrics flush period added in 8.7.0.
* Fix `Slow SQL sampling` not accurate, due to TopN works conflict with cache read-then-clear mechanism.
* The persistent cache is only read when necessary.
-* Add component definition for `Alibaba Fastjson`.
+* Add component definition for `Alibaba Fastjson` and `Jackson`.
Review comment:
All change logs in `changes` folder are archived versions, unless there are typo, they should not be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813#discussion_r716314551
##########
File path: changes/changes-8.8.0.md
##########
@@ -75,7 +75,7 @@ Release Notes.
low down metrics flush period added in 8.7.0.
* Fix `Slow SQL sampling` not accurate, due to TopN works conflict with cache read-then-clear mechanism.
* The persistent cache is only read when necessary.
-* Add component definition for `Alibaba Fastjson`.
+* Add component definition for `Alibaba Fastjson` and `Jackson`.
Review comment:
Read this, if you want to see what is happening. https://github.com/apache/skywalking/discussions/7548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7813: Add component definition for Jackson.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7813:
URL: https://github.com/apache/skywalking/pull/7813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org