[GitHub] clintropolis commented on a change in pull request #6502: bloom filter sql

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #6502: bloom filter sql
URL: https://github.com/apache/incubator-druid/pull/6502#discussion_r234793183
 
 

 ##########
 File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/guice/BloomFilterExtensionModule.java
 ##########
 @@ -38,6 +40,9 @@
   @Override
   public void configure(Binder binder)
   {
-
+    if (binder != null) {
+      // Binder is null in some tests (apparently, idk i copied this from ApproximateHistogramModule).
 
 Review comment:
   Thanks for the explanation, I meant to look into this and remove the comment if not applicable but spaced it, will check it out

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org