You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/25 11:39:58 UTC
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1405: Ftr: Added more event distribution types and improved event distribution mechanism for 1.5
ChangedenCZD commented on a change in pull request #1405:
URL: https://github.com/apache/dubbo-go/pull/1405#discussion_r695668122
##########
File path: config/config_loader.go
##########
@@ -247,11 +257,22 @@ func loadProviderConfig() {
svs.id = key
svs.Implement(rpcService)
svs.Protocols = providerConfig.Protocols
- if err := svs.Export(); err != nil {
- panic(fmt.Sprintf("service %s export failed! err: %#v", key, err))
+ err := svs.Export()
+ serviceURL := svs.getValidURL()
+ if err != nil {
+ errMsg := fmt.Sprintf("service %s export failed! err: %#v", key, err)
+ svs.postProcessConfig(serviceURL, &map[string]string{
Review comment:
这个URL是clone出来的，不会影响到用于refer、export的URL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org