[GitHub] erisu commented on a change in pull request #289: CB-14075: (windows) Remove Node 4 from CI - cordova-windows

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #289: CB-14075: (windows) Remove Node 4 from CI - cordova-windows
URL: https://github.com/apache/cordova-windows/pull/289#discussion_r207170402
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -1,15 +1,21 @@
 language: node_js
 sudo: false
+
 git:
   depth: 10
+
 node_js:
-  - "4"
   - "6"
+  - "8"
+  - "10"
+
 install:
-    - npm install
-    - npm install -g codecov
+  - npm install
 
 Review comment:
   I noticed some were indented with 2 spaces while others were 4. Typically I indent things with 2 spaces also, so I went ahead and modified them to at least be in uniform with the others. 
   
   There are no problems if I had left it alone. Travis CI, at least, does not enforce an indention rule for their YAML files while others have been known to enforce two space.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org