You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Peter Somogyi <ps...@apache.org> on 2019/09/13 07:26:46 UTC
[DISCUSS] Storing images in source repository
Hi,
Recently the hbtop tool (HBASE-11062) was merged and it also includes a
nice README documentation with demos in GIF format.
Although I think we should have more documentation like this, probably it
is not a good idea to store the images in the source repository. The size
of these GIF images is 31MB which is not huge, however, it will be included
in the release tarballs from now on and every time we pull the repository
for the builds it adds +31MB every time.
My recommendation is to keep similar images in a different place, for
example in the hbase-site repository and link the images from there.
Thanks,
Peter
Re: [DISCUSS] Storing images in source repository
Posted by Sean Busbey <bu...@apache.org>.
Sounds good to me.
Maybe a comment in the hbtop readme source with a pointer about how to
update the image content since folks might not know to look at hbase-site?
On Fri, Sep 13, 2019, 02:27 Peter Somogyi <ps...@apache.org> wrote:
> Hi,
>
> Recently the hbtop tool (HBASE-11062) was merged and it also includes a
> nice README documentation with demos in GIF format.
>
> Although I think we should have more documentation like this, probably it
> is not a good idea to store the images in the source repository. The size
> of these GIF images is 31MB which is not huge, however, it will be included
> in the release tarballs from now on and every time we pull the repository
> for the builds it adds +31MB every time.
>
> My recommendation is to keep similar images in a different place, for
> example in the hbase-site repository and link the images from there.
>
> Thanks,
> Peter
>
Re: [DISCUSS] Storing images in source repository
Posted by Toshihiro Suzuki <br...@apache.org>.
> We should not rewrite history. It will remain there but when you do
shallow
> clone it won't fetch this data. Our build jobs only fetch the latest 50
> commits currently.
Okay. So I will just move the images to the hbase-site repository (
https://github.com/apache/hbase-site)
and the README itself to the HBase Book in HBASE-22986
<https://issues.apache.org/jira/browse/HBASE-22986>.
Thanks,
Toshi
On Mon, Sep 16, 2019 at 9:24 PM Peter Somogyi <ps...@apache.org> wrote:
> > I think we can do it in
> https://issues.apache.org/jira/browse/HBASE-22986.
>
> Sounds good!
>
> > To avoid this, I think we need to remove the images from the history of
> the
> source repository maybe by using filter-branch?
>
> We should not rewrite history. It will remain there but when you do shallow
> clone it won't fetch this data. Our build jobs only fetch the latest 50
> commits currently.
>
> Peter
>
> On Mon, Sep 16, 2019 at 11:01 AM Toshihiro Suzuki <br...@apache.org>
> wrote:
>
> > Sounds good to me.
> >
> > So, should we move the images to the hbase-site repository (
> > https://github.com/apache/hbase-site)
> > and move the README itself to the HBase Book?
> > I think we can do it in
> https://issues.apache.org/jira/browse/HBASE-22986.
> >
> >
> > > every time we pull the repository for the builds it adds +31MB every
> > time.
> >
> > To avoid this, I think we need to remove the images from the history of
> the
> > source repository maybe by using filter-branch?
> > https://git-scm.com/docs/git-filter-branch
> >
> > What do you guys think?
> >
> >
> > On Sat, Sep 14, 2019 at 10:28 AM Andrew Purtell <
> andrew.purtell@gmail.com>
> > wrote:
> >
> > > Sounds good to me. We have been separating out resources for site and
> > > documentation from the main repo to others for a while. Let’s continue
> > > doing that. So probably the big hbtop readme and associated resources
> > > should go into the online book and the docs in the source tree should
> > refer
> > > to the new book section.
> > >
> > >
> > > > On Sep 13, 2019, at 4:26 PM, Peter Somogyi <ps...@apache.org>
> > wrote:
> > > >
> > > > Hi,
> > > >
> > > > Recently the hbtop tool (HBASE-11062) was merged and it also
> includes a
> > > > nice README documentation with demos in GIF format.
> > > >
> > > > Although I think we should have more documentation like this,
> probably
> > it
> > > > is not a good idea to store the images in the source repository. The
> > size
> > > > of these GIF images is 31MB which is not huge, however, it will be
> > > included
> > > > in the release tarballs from now on and every time we pull the
> > repository
> > > > for the builds it adds +31MB every time.
> > > >
> > > > My recommendation is to keep similar images in a different place, for
> > > > example in the hbase-site repository and link the images from there.
> > > >
> > > > Thanks,
> > > > Peter
> > >
> >
>
Re: [DISCUSS] Storing images in source repository
Posted by Peter Somogyi <ps...@apache.org>.
> I think we can do it in https://issues.apache.org/jira/browse/HBASE-22986.
Sounds good!
> To avoid this, I think we need to remove the images from the history of
the
source repository maybe by using filter-branch?
We should not rewrite history. It will remain there but when you do shallow
clone it won't fetch this data. Our build jobs only fetch the latest 50
commits currently.
Peter
On Mon, Sep 16, 2019 at 11:01 AM Toshihiro Suzuki <br...@apache.org>
wrote:
> Sounds good to me.
>
> So, should we move the images to the hbase-site repository (
> https://github.com/apache/hbase-site)
> and move the README itself to the HBase Book?
> I think we can do it in https://issues.apache.org/jira/browse/HBASE-22986.
>
>
> > every time we pull the repository for the builds it adds +31MB every
> time.
>
> To avoid this, I think we need to remove the images from the history of the
> source repository maybe by using filter-branch?
> https://git-scm.com/docs/git-filter-branch
>
> What do you guys think?
>
>
> On Sat, Sep 14, 2019 at 10:28 AM Andrew Purtell <an...@gmail.com>
> wrote:
>
> > Sounds good to me. We have been separating out resources for site and
> > documentation from the main repo to others for a while. Let’s continue
> > doing that. So probably the big hbtop readme and associated resources
> > should go into the online book and the docs in the source tree should
> refer
> > to the new book section.
> >
> >
> > > On Sep 13, 2019, at 4:26 PM, Peter Somogyi <ps...@apache.org>
> wrote:
> > >
> > > Hi,
> > >
> > > Recently the hbtop tool (HBASE-11062) was merged and it also includes a
> > > nice README documentation with demos in GIF format.
> > >
> > > Although I think we should have more documentation like this, probably
> it
> > > is not a good idea to store the images in the source repository. The
> size
> > > of these GIF images is 31MB which is not huge, however, it will be
> > included
> > > in the release tarballs from now on and every time we pull the
> repository
> > > for the builds it adds +31MB every time.
> > >
> > > My recommendation is to keep similar images in a different place, for
> > > example in the hbase-site repository and link the images from there.
> > >
> > > Thanks,
> > > Peter
> >
>
Re: [DISCUSS] Storing images in source repository
Posted by Toshihiro Suzuki <br...@apache.org>.
Sounds good to me.
So, should we move the images to the hbase-site repository (
https://github.com/apache/hbase-site)
and move the README itself to the HBase Book?
I think we can do it in https://issues.apache.org/jira/browse/HBASE-22986.
> every time we pull the repository for the builds it adds +31MB every time.
To avoid this, I think we need to remove the images from the history of the
source repository maybe by using filter-branch?
https://git-scm.com/docs/git-filter-branch
What do you guys think?
On Sat, Sep 14, 2019 at 10:28 AM Andrew Purtell <an...@gmail.com>
wrote:
> Sounds good to me. We have been separating out resources for site and
> documentation from the main repo to others for a while. Let’s continue
> doing that. So probably the big hbtop readme and associated resources
> should go into the online book and the docs in the source tree should refer
> to the new book section.
>
>
> > On Sep 13, 2019, at 4:26 PM, Peter Somogyi <ps...@apache.org> wrote:
> >
> > Hi,
> >
> > Recently the hbtop tool (HBASE-11062) was merged and it also includes a
> > nice README documentation with demos in GIF format.
> >
> > Although I think we should have more documentation like this, probably it
> > is not a good idea to store the images in the source repository. The size
> > of these GIF images is 31MB which is not huge, however, it will be
> included
> > in the release tarballs from now on and every time we pull the repository
> > for the builds it adds +31MB every time.
> >
> > My recommendation is to keep similar images in a different place, for
> > example in the hbase-site repository and link the images from there.
> >
> > Thanks,
> > Peter
>
Re: [DISCUSS] Storing images in source repository
Posted by Andrew Purtell <an...@gmail.com>.
Sounds good to me. We have been separating out resources for site and documentation from the main repo to others for a while. Let’s continue doing that. So probably the big hbtop readme and associated resources should go into the online book and the docs in the source tree should refer to the new book section.
> On Sep 13, 2019, at 4:26 PM, Peter Somogyi <ps...@apache.org> wrote:
>
> Hi,
>
> Recently the hbtop tool (HBASE-11062) was merged and it also includes a
> nice README documentation with demos in GIF format.
>
> Although I think we should have more documentation like this, probably it
> is not a good idea to store the images in the source repository. The size
> of these GIF images is 31MB which is not huge, however, it will be included
> in the release tarballs from now on and every time we pull the repository
> for the builds it adds +31MB every time.
>
> My recommendation is to keep similar images in a different place, for
> example in the hbase-site repository and link the images from there.
>
> Thanks,
> Peter