You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Samuelson <pe...@p12n.org> on 2006/04/25 21:54:35 UTC
Re: svn commit: r19318 - trunk/subversion/tests/cmdline/svntest
[mhagger@tigris.org]
> - return not self.test_case.convert_result(result)
> + return {0:1, 1:0, 2:2}[self.test_case.convert_result(result)]
return (1,0,2)[self.test_case.convert_result(result)]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r19318 - trunk/subversion/tests/cmdline/svntest
Posted by Michael Haggerty <mh...@alum.mit.edu>.
Peter Samuelson wrote:
> [mhagger@tigris.org]
>
>>- return not self.test_case.convert_result(result)
>>+ return {0:1, 1:0, 2:2}[self.test_case.convert_result(result)]
>
> return (1,0,2)[self.test_case.convert_result(result)]
I considered your variant, but thought that the dictionary variant makes
the code's intention clearer. It also produces a clear error if
convert_result() should accidentally return a value in (-3, -2, -1).
Also, I plan to introduce symbolic contants for 0, 1, and 2, after which
the tuple version would be quite obscure :-)
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org