You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Dmitriy Lyubimov (JIRA)" <ji...@apache.org> on 2011/03/26 03:35:05 UTC
[jira] [Issue Comment Edited] (MAHOUT-622) Mahout dependencies are
unified under dependency management in parent pom
[ https://issues.apache.org/jira/browse/MAHOUT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011533#comment-13011533 ]
Dmitriy Lyubimov edited comment on MAHOUT-622 at 3/26/11 2:34 AM:
------------------------------------------------------------------
First cleanup of core.pom. All tests pass.
I think since pom files are highly competitive and i am moving rather slowly with this, i would like to commit this more often instead of cleaning it all up at once. So i will do it module by module. Any objections?
*This patch is not final* but per above I'd like to commit this issue in several steps, so this is for review.
Thank you.
was (Author: dlyubimov):
First cleanup of core.pom. All tests pass.
I think since pom files are highly competitive and i am moving rather slowly with this, i would like to commit this more often instead of cleaning it all up at once. So i will do it module by module. Any objections?
Thank you.
> Mahout dependencies are unified under dependency management in parent pom
> -------------------------------------------------------------------------
>
> Key: MAHOUT-622
> URL: https://issues.apache.org/jira/browse/MAHOUT-622
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.4
> Reporter: Dmitriy Lyubimov
> Assignee: Dmitriy Lyubimov
> Priority: Minor
> Labels: build, maven, pom
> Fix For: 0.5
>
> Attachments: MAHOUT-622.patch
>
>
> As far as I understand, Maven encourages "best practice" of unified view of dependency versions specified under <dependencyManagement> usually in a parent pom, instead of under <dependencies>.
> In Mahout, this practice is only partially followed. Some dependencies have concrete versions under <dependencies> tag in submodule poms. Proposed change is to raid those and move version declarations into parent pom.
> This (as far as i understand) achieves 2 things:
> * Mahout assembly would include same versions for all modules thus ensuring runtime module dependencies are the same as compile time;
> * Somebody who uses Mahout as a dependency, could import Mahout dependencies using <scope>import</scope> spec thus inheriting Mahout's versions for shared dependencies.
> For most part the change would be nominal although in certain cases we'd need to sort out through cross-module conflicts (if any). Commons-math was one, not sure if there are more. If there are none, the changes would be rather mechanistic.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira